griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Drivers Editor: apply red underline to drivers that failed evaluation.

Browse Source 
F-Curves with a broken rna path are highlighted with a red underline
in the channel list of the animation editors. I think it makes sense
to also apply this to drivers that failed to evaluate and were disabled.

Otherwise, it is not apparent which drivers are broken without checking
every one manually, or applying the errors filter.
This commit is contained in:
Alexander Gavrilov
2023-07-29 15:47:04 +03:00
parent 1db4ed50e8
commit b9074381e5
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
source/blender/editors/animation/anim_channels_defines.cc
View File

@@ -4559,6 +4559,23 @@ static bool achannel_is_being_renamed(const bAnimContext *ac,
return false;
}
/** Check if the animation channel name should be underlined in red due to fatal errors. */
static bool achannel_is_broken(const bAnimListElem *ale)
{
switch (ale->type) {
case ANIMTYPE_FCURVE:
case ANIMTYPE_NLACURVE: {
const FCurve *fcu = static_cast<const FCurve *>(ale->data);
/* The channel is disabled (has a bad rna path), or it's a driver that failed to evaluate. */
return (ale->flag & FCURVE_DISABLED) ||
(fcu->driver != nullptr && (fcu->driver->flag & DRIVER_FLAG_INVALID));
}
default:
return false;
}
}
float ANIM_UI_get_keyframe_scale_factor()
{
bTheme *btheme = UI_GetTheme();
@@ -4742,7 +4759,7 @@ void ANIM_channel_draw(
UI_fontstyle_draw_simple(fstyle, offset, ytext, name, col);
/* draw red underline if channel is disabled */
if (ELEM(ale->type, ANIMTYPE_FCURVE, ANIMTYPE_NLACURVE) && (ale->flag & FCURVE_DISABLED)) {
if (achannel_is_broken(ale)) {
uint pos = GPU_vertformat_attr_add(
immVertexFormat(), "pos", GPU_COMP_F32, 2, GPU_FETCH_FLOAT);