griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #144521: Unable to fetch LFS objects on make update with Glthub mirror

Browse Source 
The setting is called `lfs.remote.searchall`, the `remote` part of it being
an exact string, it is not to be expanded with the name of the remote.

Whenever name of the remote is to be used Git documentation uses `<remote>`
syntax.

Tested by triggering the original issue (clone the Github mirror, make update,
wait for a new LFS object appear in the upstream, make update again). Before
this change the LFS object will not be fetched, and based on the Git Curl's
log only the github origin was used to fetch LFS object, none other remotes
were tried.

Also confirmed by checking the Git-LFS code:
https://github.com/git-lfs/git-lfs/blob/v3.7.0/config/config.go#L232

Pull Request: https://projects.blender.org/blender/blender/pulls/144574
This commit is contained in:
Sergey Sharybin
2025-08-14 17:51:52 +02:00
committed by Sergey Sharybin
parent 7c7af11b9b
commit cfd04172c9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build_files/utils/make_update.py
View File

@@ -647,7 +647,7 @@ def lfs_fallback_setup(args: argparse.Namespace) -> None:
for remote in remotes: for remote in remotes:
url = make_utils.git_get_remote_url(args.git_command, remote) url = make_utils.git_get_remote_url(args.git_command, remote)
if "projects.blender.org" not in url and "git.blender.org" not in url: if "projects.blender.org" not in url and "git.blender.org" not in url:
make_utils.git_set_config(args.git_command, f"lfs.{remote}.searchall", "true") make_utils.git_set_config(args.git_command, "lfs.remote.searchall", "true")
else: else:
add_fallback_remote = False add_fallback_remote = False