griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #35074: Image editor shows color banding on rendered images (even with dither set to 2.0)

Browse Source 
Mistake in one of changes to GLSL display function,
missed fallback mode in case dither is non-zero,
This commit is contained in:
Sergey Sharybin
2013-04-25 12:02:56 +00:00
parent f4d37847af
commit d0b74452ad
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/screen/glutil.c
View File

@@ -1043,15 +1043,15 @@ void glaDrawImBuf_glsl(ImBuf *ibuf, float x, float y, int zoomfilter,
return;
/* Dithering is not supported on GLSL yet */
// force_fallback = ibuf->dither != 0.0f;
force_fallback |= ibuf->dither != 0.0f;
/* Single channel images could not be transformed using GLSL yet */
// force_fallback = ibuf->channels == 1;
force_fallback |= ibuf->channels == 1;
/* If user decided not to use GLSL, fallback to glaDrawPixelsAuto */
force_fallback = !ELEM(U.image_draw_method,
IMAGE_DRAW_METHOD_AUTO,
IMAGE_DRAW_METHOD_GLSL);
force_fallback |= !ELEM(U.image_draw_method,
IMAGE_DRAW_METHOD_AUTO,
IMAGE_DRAW_METHOD_GLSL);
/* This is actually lots of crap, but currently not sure about
* more clear way to bypass partial buffer update crappyness