griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix missing redraw when setting the view axis

Browse Source 
When the viewport orientation matched the view axis,
setting an axis view didn't redraw the region.

This caused the viewport text & grid not to update.
This commit is contained in:
Campbell Barton
2024-09-10 17:31:05 +10:00
parent 9d6ecd0ed6
commit d122d19f00
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
source/blender/editors/space_view3d/view3d_navigate.cc
View File

@@ -897,6 +897,8 @@ void axis_set_view(bContext *C,
float quat[4];
const short orig_persp = rv3d->persp;
const char orig_view = rv3d->view;
const char orig_view_axis_roll = rv3d->view_axis_roll;
normalize_qt_qt(quat, quat_);
@@ -905,14 +907,21 @@ void axis_set_view(bContext *C,
rv3d->view = view = RV3D_VIEW_USER;
rv3d->view_axis_roll = RV3D_VIEW_AXIS_ROLL_0;
}
if (align_to_quat == nullptr) {
else {
rv3d->view = view;
rv3d->view_axis_roll = view_axis_roll;
}
if (RV3D_LOCK_FLAGS(rv3d) & RV3D_LOCK_ROTATION) {
/* Redrawing when changes are detected is needed because the current view
* orientation may be a "User" view that matches the axis exactly.
* In this case smooth-view exits early as no view transition is needed.
* However, changing the view must redraw the region as it changes the
* viewport name & grid drawing. */
if ((rv3d->view != orig_view) || (rv3d->view_axis_roll != orig_view_axis_roll)) {
ED_region_tag_redraw(region);
}
if (RV3D_LOCK_FLAGS(rv3d) & RV3D_LOCK_ROTATION) {
return;
}
@@ -922,6 +931,9 @@ void axis_set_view(bContext *C,
else if (rv3d->persp == RV3D_CAMOB) {
rv3d->persp = perspo;
}
if ((rv3d->persp != orig_persp)) {
ED_region_tag_redraw(region);
}
if (rv3d->persp == RV3D_CAMOB && v3d->camera) {
/* to camera */