griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: EEVEE: Simplify computation in #ltc_evaluate_disk_simple

Browse Source 
The existing code was copied from the ellipse light case. But
this computation simplifies for the disk case, removing the
need of `inversesqrt`.

Pull Request: https://projects.blender.org/blender/blender/pulls/108616
This commit is contained in:
Weizhen Huang
2023-06-05 14:21:38 +02:00
committed by Clément Foucault
parent ebb5643e59
commit d54fe40807
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/draw/engines/eevee/shaders/ltc_lib.glsl
View File

@@ -189,8 +189,7 @@ float ltc_evaluate_quad(vec3 corners[4], vec3 N)
float ltc_evaluate_disk_simple(float disk_radius, float NL)
{
float r_sqr = disk_radius * disk_radius;
float one_r_sqr = 1.0 + r_sqr;
float form_factor = r_sqr * inversesqrt(one_r_sqr * one_r_sqr);
float form_factor = r_sqr / (1.0 + r_sqr);
return form_factor * diffuse_sphere_integral(NL, form_factor);
}

3
source/blender/draw/engines/eevee_next/shaders/eevee_ltc_lib.glsl
View File

@@ -179,8 +179,7 @@ float ltc_evaluate_quad(sampler2DArray utility_tx, vec3 corners[4], vec3 N)
float ltc_evaluate_disk_simple(sampler2DArray utility_tx, float disk_radius, float NL)
{
float r_sqr = disk_radius * disk_radius;
float one_r_sqr = 1.0 + r_sqr;
float form_factor = r_sqr * inversesqrt(one_r_sqr * one_r_sqr);
float form_factor = r_sqr / (1.0 + r_sqr);
return form_factor * ltc_diffuse_sphere_integral(utility_tx, NL, form_factor);
}