griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #115930: custom colored bones are invisible when drawn in stick mode

Browse Source 
The fix here is simple: we ignore the alpha channel in the bone theme
colors, setting it unconditionally to fully opaque.  This is correct
because conceptually the bone theme colors are just RGB, not RGBA,
and the alpha channel doesn't always get set consistently.

Pull Request: https://projects.blender.org/blender/blender/pulls/121256
This commit is contained in:
Nathan Vegdahl
2024-04-30 15:25:21 +02:00
committed by Nathan Vegdahl
parent 08de3fa0b6
commit d5a4b98323
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/draw/engines/overlay/overlay_armature.cc
View File

@@ -1137,8 +1137,10 @@ static void cp_shade_color3ub(uchar cp[3], const int offset)
*/
static void use_bone_color(float *r_color, const uint8_t *color_from_theme, const int shade_offset)
{
uint8_t srgb_color[4];
copy_v4_v4_uchar(srgb_color, color_from_theme);
uint8_t srgb_color[4] = {255, 255, 255, 255};
/* Only copy RGB, not alpha. The "alpha" channel in the bone theme colors is
* essentially just padding, and should be ignored. */
copy_v3_v3_uchar(srgb_color, color_from_theme);
if (shade_offset != 0) {
cp_shade_color3ub(srgb_color, shade_offset);
}