griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Crash in single value input to Glare node

Browse Source 
The Glare node crashes in the full-frame compositor when its input is a
single value. Since the Glare node is constant foldable, do not inflate
its input and instead output a single value.
This commit is contained in:
Omar Emara
2023-12-21 14:48:33 +02:00
parent e055db6605
commit dea7d65ee7
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/compositor/operations/COM_GlareBaseOperation.cc
View File

@@ -75,17 +75,14 @@ void GlareBaseOperation::update_memory_buffer(MemoryBuffer *output,
{
if (!is_output_rendered_) {
MemoryBuffer *input = inputs[0];
const bool is_input_inflated = input->is_a_single_elem();
if (is_input_inflated) {
input = input->inflate();
if (input->is_a_single_elem()) {
copy_v4_v4(output->get_elem(0, 0), input->get_elem(0, 0));
is_output_rendered_ = true;
return;
}
this->generate_glare(output->get_buffer(), input, settings_);
is_output_rendered_ = true;
if (is_input_inflated) {
delete input;
}
}
}