griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Sculpt: Remove unnecessary visibility flushing

Browse Source 
Face set code modifies visibility of faces, then flushes those changes
to vertex and edge visibility. However, then it did an extra flush back
from vertices to faces and edges, which shouldn't be necessary.
This commit is contained in:
Hans Goudey
2023-08-01 21:25:38 -04:00
parent 12258d4931
commit e4e23bdd73
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/sculpt_paint/sculpt_face_set.cc
View File

@@ -718,10 +718,6 @@ static int sculpt_face_set_init_exec(bContext *C, wmOperator *op)
BKE_pbvh_update_vertex_data(ss->pbvh, PBVH_UpdateVisibility);
if (BKE_pbvh_type(pbvh) == PBVH_FACES) {
BKE_mesh_flush_hidden_from_verts(mesh);
}
SCULPT_tag_update_overlays(C);
return OPERATOR_FINISHED;
@@ -1307,8 +1303,6 @@ static void sculpt_face_set_edit_modify_geometry(bContext *C,
static void face_set_edit_do_post_visibility_updates(Object *ob, Span<PBVHNode *> nodes)
{
SculptSession *ss = ob->sculpt;
PBVH *pbvh = ss->pbvh;
Mesh *mesh = static_cast<Mesh *>(ob->data);
/* Sync face sets visibility and vertex visibility as now all Face Sets are visible. */
SCULPT_visibility_sync_all_from_faces(ob);
@@ -1318,10 +1312,6 @@ static void face_set_edit_do_post_visibility_updates(Object *ob, Span<PBVHNode *
}
BKE_pbvh_update_vertex_data(ss->pbvh, PBVH_UpdateVisibility);
if (BKE_pbvh_type(pbvh) == PBVH_FACES) {
BKE_mesh_flush_hidden_from_verts(mesh);
}
}
static void sculpt_face_set_edit_modify_face_sets(Object *ob,