griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Remove unnecessary template in curve subdivide node

Browse Source 
The Catmull Rom curve subdivision arguments use runtime-typed spans,
so the template doesn't help anyway. Makes Blender 27 KB smaller.
This commit is contained in:
Hans Goudey
2023-05-23 19:57:35 -04:00
parent fa8351486f
commit e704ebaba4
1 changed files with 2 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
source/blender/geometry/intern/subdivide_curves.cc
View File

@@ -112,14 +112,13 @@ static void subdivide_attribute_linear(const OffsetIndices<int> src_points_by_cu
});
}
template<typename T>
static void subdivide_attribute_catmull_rom(const OffsetIndices<int> src_points_by_curve,
const OffsetIndices<int> dst_points_by_curve,
const IndexMask selection,
const Span<int> all_point_offsets,
const Span<bool> cyclic,
const Span<T> src,
MutableSpan<T> dst)
const GSpan src,
GMutableSpan dst)
{
threading::parallel_for(selection.index_range(), 512, [&](IndexRange selection_range) {
for (const int curve_i : selection.slice(selection_range)) {
@@ -135,26 +134,6 @@ static void subdivide_attribute_catmull_rom(const OffsetIndices<int> src_points_
});
}
static void subdivide_attribute_catmull_rom(const OffsetIndices<int> src_points_by_curve,
const OffsetIndices<int> dst_points_by_curve,
const IndexMask selection,
const Span<int> all_point_offsets,
const Span<bool> cyclic,
const GSpan src,
GMutableSpan dst)
{
bke::attribute_math::convert_to_static_type(dst.type(), [&](auto dummy) {
using T = decltype(dummy);
subdivide_attribute_catmull_rom(src_points_by_curve,
dst_points_by_curve,
selection,
all_point_offsets,
cyclic,
src.typed<T>(),
dst.typed<T>());
});
}
static void subdivide_bezier_segment(const float3 &position_prev,
const float3 &handle_prev,
const float3 &handle_next,