griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #130669: EEVEE: Filter Size of 0 doesn't result in sharp viewport if using pixel scaling

Browse Source 
Clamping the filter size when using scaling factor > 1 fixes
the issue.
Without this, the filter becomes a dirac and samples gets
only the fallback weight. This would results in a box
blur instead of no filtering.
This commit is contained in:
Clément Foucault
2024-11-22 13:03:53 +01:00
parent b8ace9331c
commit f08979cb3f
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/draw/engines/eevee_next/eevee_film.cc
View File

@@ -329,9 +329,18 @@ void Film::init(const int2 &extent, const rcti *output_rect)
data_.overscan = overscan_pixels_get(inst_.camera.overscan(), data_.render_extent);
data_.render_extent += data_.overscan * 2;
/* Disable filtering if sample count is 1. */
data_.filter_radius = (sampling.sample_count() == 1) ? 0.0f :
clamp_f(scene.r.gauss, 0.0f, 100.0f);
data_.filter_radius = clamp_f(scene.r.gauss, 0.0f, 100.0f);
if (sampling.sample_count() == 1) {
/* Disable filtering if sample count is 1. */
data_.filter_radius = 0.0f;
}
if (data_.scaling_factor > 1) {
/* Fixes issue when using scaling factor and no filtering.
* Without this, the filter becomes a dirac and samples gets only the fallback weight.
* This results in a box blur instead of no filtering. */
data_.filter_radius = math::max(data_.filter_radius, 0.0001f);
}
data_.cryptomatte_samples_len = inst_.view_layer->cryptomatte_levels;
data_.background_opacity = (scene.r.alphamode == R_ALPHAPREMUL) ? 0.0f : 1.0f;