griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Metal: Fix clang-tidy warnings

Browse Source 
Replace != "" by more semanticaly friendly `is_empty`.
This commit is contained in:
Clément Foucault
2024-11-10 00:22:27 +01:00
parent 33482bdd3a
commit f67ea33993
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/gpu/metal/mtl_shader_generator.mm
View File

@@ -2776,7 +2776,7 @@ std::string MSLGeneratorInterface::generate_msl_vertex_output_population()
out << "\toutput." << v_out.instance_name << "_" << v_out.name << i << " = "
<< shader_stage_inst_name << ".";
if (v_out.instance_name != "") {
if (v_out.instance_name.empty() == false) {
out << v_out.instance_name << ".";
}
@@ -2791,7 +2791,7 @@ std::string MSLGeneratorInterface::generate_msl_vertex_output_population()
out << "\toutput." << v_out.instance_name << "__matrix_" << v_out.name << elem << " = "
<< shader_stage_inst_name << ".";
if (v_out.instance_name != "") {
if (v_out.instance_name.empty() == false) {
out << v_out.instance_name << ".";
}
@@ -2816,7 +2816,7 @@ std::string MSLGeneratorInterface::generate_msl_vertex_output_population()
out << "\toutput." << v_out.instance_name << "_" << v_out.name << " = "
<< shader_stage_inst_name << ".";
if (v_out.instance_name != "") {
if (v_out.instance_name.empty() == false) {
out << v_out.instance_name << ".";
}
@@ -2919,7 +2919,7 @@ std::string MSLGeneratorInterface::generate_msl_fragment_input_population()
for (int i = 0; i < this->fragment_input_varyings[f_input].array_elems; i++) {
out << "\t" << shader_stage_inst_name << ".";
if (this->fragment_input_varyings[f_input].instance_name != "") {
if (this->fragment_input_varyings[f_input].instance_name.empty() == false) {
out << this->fragment_input_varyings[f_input].instance_name << ".";
}
@@ -2933,7 +2933,7 @@ std::string MSLGeneratorInterface::generate_msl_fragment_input_population()
if (is_matrix_type(this->fragment_input_varyings[f_input].type)) {
out << "\t" << shader_stage_inst_name << ".";
if (this->fragment_input_varyings[f_input].instance_name != "") {
if (this->fragment_input_varyings[f_input].instance_name.empty() == false) {
out << this->fragment_input_varyings[f_input].instance_name << ".";
}
@@ -2951,7 +2951,7 @@ std::string MSLGeneratorInterface::generate_msl_fragment_input_population()
else {
out << "\t" << shader_stage_inst_name << ".";
if (this->fragment_input_varyings[f_input].instance_name != "") {
if (this->fragment_input_varyings[f_input].instance_name.empty() == false) {
out << this->fragment_input_varyings[f_input].instance_name << ".";
}