Commit Graph

120055 Commits

Author SHA1 Message Date
Hans Goudey
a7c7e58a4c Sculpt: Data oriented factors calculation for paint brushes
Part of #118145.

Store intermediate data (factors and distances) in thread local storage
for the paint and smear color brushes. The rest of the brushes aren't
refactored to the new "standard", but most of the code we want to
remove in the short term isn't used anymore.
2024-07-03 14:52:15 -04:00
Hans Goudey
0b44d3d163 Cleanup: Sculpt: Use const SculptSession arguments 2024-07-03 14:52:15 -04:00
Hans Goudey
f8fc28bea9 Refactor: Sculpt: Add API function for accessing original color data 2024-07-03 14:52:15 -04:00
Hans Goudey
6fce121596 Cleanup: Sculpt: Simplify vertex position access in color smear brush 2024-07-03 14:52:15 -04:00
Sean Kim
b2ec10184c Sculpt: Initial data oriented refactor for draw face sets brush
Part of #118145.

Performance after this change results in an 156% speedup. This is
measured on the function `stroke_update_step` on a mesh with 24k verts
across 20k instances of the function being timed. In absolute values,
this represents a 0.09ms speedup, from 0.16ms to 0.25ms.

For BMesh, the brush now takes mask values into consideration by
averaging all of the vert mask values for a face.

Co-authored-by: Hans Goudey <hans@blender.org>
Pull Request: https://projects.blender.org/blender/blender/pulls/123811
2024-07-03 20:46:36 +02:00
Harley Acheson
c468319497 UI: Use Large Blender Logo for Blend File in File Browser
For times when we show the blender logo inside a larger document image,
use the version meant for larger sizes. The complexity is almost
identical, but we use it larger here so use the nicer one.

Pull Request: https://projects.blender.org/blender/blender/pulls/124117
2024-07-03 19:16:40 +02:00
Harley Acheson
c6411e61ae Fix: Handle Missing Font in ID List Previews
Handle missing font in the hover tooltip preview in the Data-block ID
selector. Add error handing both in IMB_font_preview itself and in the
current caller (to show message).

Pull Request: https://projects.blender.org/blender/blender/pulls/124111
2024-07-03 18:24:28 +02:00
Hans Goudey
5b50bb19e7 Cleanup: Sculpt: Use C++ math types for color paint brushes 2024-07-03 12:13:52 -04:00
Hans Goudey
ad0e327dd0 Sculpt: Data oriented refactor for color smooth brush
Part of #118145.
2024-07-03 12:13:52 -04:00
Hans Goudey
ea202f83bf Cleanup: Use const SculptSession arguments 2024-07-03 12:13:52 -04:00
Harley Acheson
1992296828 Fix #124068: Update Text Style Weights With Change of UI Font
Only when the user changes the UI font to one that does not have a
variable weight axis, update the text style weights to match the font's
design weight. So if changing to an old-school font that has a fixed
weight, for example bold, also update UI Text Style weights to match
so everything looks as designed and expected.

Pull Request: https://projects.blender.org/blender/blender/pulls/124074
2024-07-03 18:02:20 +02:00
Bastien Montagne
a1e2cc2b6e Cleanup: Unused variables in non-assert release builds. 2024-07-03 16:33:03 +02:00
Clément Foucault
71159872a4 Fix: EEVEE: VDB renders as bounding box when using Volume Scatter
Use the same approach as Cycles and only render the volume
objects if the shader is using any attribute.

Fix #124061
2024-07-03 16:27:08 +02:00
Lukas Stockner
e2d77fbc1c Cleanup: Remove outdated asserts
61fb25cb94 removed the factors argument.
2024-07-03 16:01:38 +02:00
Sergey Sharybin
35788ca3c9 Merge branch 'blender-v4.2-release' 2024-07-03 16:01:21 +02:00
Hans Goudey
78e9621bcd Sculpt: Refactor sampling for multi-plane scrape brush
Part of #118145.
2024-07-03 09:59:25 -04:00
Hans Goudey
734e9fa4b8 Fix: MEM_new/MEM_freeN mismatch in edit mesh undo
For non-trivial custom data types, the undo system did a shallow copy of the
base array which implicitly transferred ownership of the data to the undo
system. Combined with implicit sharing, this was hacky at best, and quite
wrong at worst, since it freed the implicit sharing info incorrectly.

To fix this, free the mesh custom data with the standard function for that
and add the non-trivial layers to the undo state using implicit sharing to
avoid another copy.

Alternative to #123894 and #123884.

Pull Request: https://projects.blender.org/blender/blender/pulls/123991
2024-07-03 15:32:05 +02:00
Hans Goudey
7f4de339f8 Cleanup: Correct misleading variable name in previous commit 2024-07-03 09:21:22 -04:00
Hans Goudey
61fb25cb94 Sculpt: Separate distance filtering from calculation
Remove the filtering of factors from the brush distance calculation
function to simplify its responsibilities and to allow passing a custom
radius from the outside. Factor filtering is now done in a separate
function. Also rename the distance calculation functions.
2024-07-03 09:18:39 -04:00
Bastien Montagne
a882d289fe Cleanup: Unused vars in non-assert release builds. 2024-07-03 15:14:18 +02:00
Clément Foucault
e10dcc01bd Fix: EEVEE: Avoid loosing SSS small radius energy
This was caused by the effective radius of some
components were below the first sample radius.
This meant that the accumulation resulted in zero
weight for these components.

This patch introduce a minimum radius that can
be represented depending on the sample closest
to the center pixel. This makes sure that we
have at least one sample that will have
non-zero weight.

Fix #124031
2024-07-03 15:09:19 +02:00
Aras Pranckevicius
28d00f16d9 Merge branch 'blender-v4.2-release' 2024-07-03 16:01:55 +03:00
Aras Pranckevicius
44510662e9 Fix #123541: VSE thumbnails in some cases are drawn outside of the strip
Code was using seq->start + seq->len to figure out where the "right
side of content" is, seemingly since forever (i.e. since 997b5fe4
added strip thumbnails). But that is incorrect starting with 3.3,
where seq->len is "number of frames / samples in source media",
but that does not necessarily match number of frames in the timeline.
For movies this happens when media framerate does not match
sequencer framerate.

Use SEQ_time_content_end_frame_get instead to calculate where the
content ends.

Pull Request: https://projects.blender.org/blender/blender/pulls/124081
2024-07-03 14:59:07 +02:00
Sergey Sharybin
bd75344b2b Merge branch 'blender-v4.2-release' 2024-07-03 14:47:23 +02:00
Clément Foucault
4d2fcc5716 Fix: EEVEE: Avoid assert from empty volume object material
Also avoid drawing them at all if the material has no
volume shader.
2024-07-03 14:40:54 +02:00
Pratik Borhade
439c318098 Fix #98440: Confirm On Release in Radial Control doesn't work with RMB
Cancelling operator with RMB is hardcoded but some wants RMB to invoke
the operation as well. In such case, don't use RMB to cancel operator
and reset the radius, i.e. when both `rc->init_event` and `event->type` is RMB

Pull Request: https://projects.blender.org/blender/blender/pulls/123053
2024-07-03 14:24:02 +02:00
Alaska
1e6161759e Fix #124073: Incorrect material shadow mode versioning
Only apply EEVEE-Next material shadow versioning to materials with
surfaces. Otherwise this will break the rendering of some materials
(E.g. Volumetrics) by making the surface opaque to the camera.

Pull Request: https://projects.blender.org/blender/blender/pulls/124076
2024-07-03 14:23:40 +02:00
Pratik Borhade
e2c038218a Fix #124045: Console error when using node gesture operation
Caused by 9d4d1aea98. Not every operator
that uses lasso gesture has `smooth_stroke/radius` properties defined,
they are sculpt tool specific. When using `node link cut` tool, console
is flooded with the "property not found error".

Pull Request: https://projects.blender.org/blender/blender/pulls/124040
2024-07-03 13:21:46 +02:00
Omar Emara
eba1a49fa7 Merge branch 'blender-v4.2-release' 2024-07-03 13:31:36 +03:00
Omar Emara
81e4fa29b8 Compositor: Allow Glare node size below 6
This patch allows the size of the Glare node to be below 6. This is not
really a fix, but it is targeting the release branch because of concerns
about this limitation which din't exist for old EEVEE bloom.

Pull Request: https://projects.blender.org/blender/blender/pulls/124092
2024-07-03 12:30:42 +02:00
Omar Emara
46270f03d8 Merge branch 'blender-v4.2-release' 2024-07-03 12:29:48 +03:00
Omar Emara
30643fcf9b Fix: Bloom glare crashes when image is too small
The Bloom mode of the Glare node crashes if the input image is too
small. This is because bloom is computed using a down-sampling followed
by an up-sampling chain, and if the user supplied size is not maximum,
the computed chain length might be zero or negative, which is not
handled gracefully. To fix this, we just sanitize the chain length.

Pull Request: https://projects.blender.org/blender/blender/pulls/124089
2024-07-03 11:27:26 +02:00
Bastien Montagne
ff4fcb5169 Cleanup: Unused variables in release, non-assert builds. 2024-07-03 10:55:06 +02:00
Campbell Barton
b615091256 Merge branch 'blender-v4.2-release' 2024-07-03 16:57:15 +10:00
Campbell Barton
463c05b341 Extensions: fix missing redraw after setting tags, report adding a repo
- Report when a repository is added since it's not so clear from the
  popup that a new repository has been added.
- Fix for missing redraw after selecting all/none tags.
- Also access the tags property once instead of getting it for each
  button.
2024-07-03 16:56:01 +10:00
Hans Goudey
e26e62597d Cleanup: Sculpt: Use C++ math types/functions in displacement smear 2024-07-02 14:34:19 -04:00
Hans Goudey
4763aeff9e Cleanup: Sculpt: Specialize displacement smear vertex neighbor iteration
Part of #118145.
2024-07-02 14:34:19 -04:00
Hans Goudey
d289a1b2e6 Refactor: Sculpt: Displacement smear factors calculation
Part of #118145.
2024-07-02 14:34:19 -04:00
Hans Goudey
db73ef0f2f Sculpt: Refactor displacement smear previous displacement storage
Part of #118145.
Multithread the loop over all grid vertices, replace the PBVH vertex
iterator macro, and avoid subtractingt the limit positions in the first
loop, since we do that later anyway.
2024-07-02 14:33:42 -04:00
Hans Goudey
527e18043c Refactor: Subdiv: Add utility to evaluate all limit points in a grid 2024-07-02 14:33:42 -04:00
Hans Goudey
90049e15d6 Refactor: Sculpt: Replace iterator macro in displacement smear brush
Part of #118145.
2024-07-02 14:33:42 -04:00
Hans Goudey
68444b8906 Cleanup: Sculpt: Move displacement smear brush to separate file 2024-07-02 14:33:42 -04:00
Hans Goudey
f3d91645b0 Cleanup: Sculpt: Use utility to make node vertex array offsets 2024-07-02 14:33:42 -04:00
Hans Goudey
146d6dcf9a Sculpt: Data oriented refactor for pinch brush
Part of #118145.
Reuse the projection utility from the crease brush.
2024-07-02 14:33:42 -04:00
Jacques Lucke
fcfc42ee83 Merge branch 'blender-v4.2-release' 2024-07-02 20:33:01 +02:00
Jacques Lucke
edd1749e22 Fix #124049: object losing user count in geometry nodes modifier 2024-07-02 20:32:24 +02:00
Clément Foucault
8718aa5513 Fix: EEVEE: Film: Sub-optimal sampling at lower filter size
The `sample_disk` returns samples inside a disk of radius 1
which was spanning 2 pixels. The blackmann-haris filter has
not much energy at the edge of the filter and since we
don't importance sample the filter, we have very low weight
samples at some time steps. Improve this by biasing the
distribution towards the center.

This is a temporary solution until we have proper importance
sample of the filtering function for this case.

Fix #123630
2024-07-02 20:31:20 +02:00
Clément Foucault
04b460317a Fix: EEVEE: Missing diffuse indirect lighting
Cause by lightprobe volume cache size change.

This was missing a simple update tagging for
the world to be reuploaded.
2024-07-02 18:07:09 +02:00
Omar Emara
39b47318e5 Compositor: Add warning about unsupported texture nodes
Add a warning to the compositor Texture node about the fact that texture
nodes are not supported.
2024-07-02 18:51:38 +03:00
Omar Emara
7dfc16141c Merge branch 'blender-v4.2-release' 2024-07-02 18:13:28 +03:00