Commit Graph

49420 Commits

Author SHA1 Message Date
Antony Riakiotakis
98a78963be Fix crashes with timers.
Incorrectly accessing the menu pointer, set it to NULL before doing the
tests.

We don't restore the menu pointer because it is invalid by the time the operator ends.
2014-09-18 16:02:40 +02:00
Antony Riakiotakis
070ce416b9 One last tweak to palette deletion code. It would correct active color
only when deleting the last color.
2014-09-18 13:03:02 +02:00
Antony Riakiotakis
90c1afb020 Fix T41708, active palette indicator not refreshing when clicking
Issue, after a lot of blood sweat and tears, was found in
ui_but_update_from_old_block, where we restore a button to its old
values when possible. The problem here is that a1 and a2 are not really
meant to store temporary variables, because they tend to get overriden
and palette selection is one of those temporary states.

Instead, we now store the position of each button in the palette in a2
and pointer to the palette in the customdata pointer of each button and
use that to test if it's active. The positions won't change when
clicking so we are guaranteed that the old button won't override the new
one with garbage.

It's still hacky but it is better than testing button types when copying
old values.
2014-09-18 12:51:54 +02:00
Antony Riakiotakis
44121442e9 Palette active color:
Use indicator color derived from color luminance for better contrast.
2014-09-18 12:20:34 +02:00
Antony Riakiotakis
b247e19ff1 Palettes
* Remove some duplication in deletion code
* Fix crash when restoring file from last saved state.
2014-09-18 12:07:17 +02:00
Antony Riakiotakis
e6271d2367 Palettes:
Avoid having an invalid active index if user deletes a color.

Also attempt to set active color on clicking (Not working yet but fix
coming soon)
2014-09-18 11:16:31 +02:00
Tamito Kajiyama
f87ca5f1c3 Fix for missing Freestyle sections in the Blender Python API documentation.
Freestyle sections of the API docs were empty due to Freestyle module reorganization
in commit rB6498b96ce7081db039354228213d72e8c70bd3aa.

Module __all__ property was added to submodules so as to properly exclude irrelevant
documentation elements such as mathutils.Vector.
2014-09-18 15:48:15 +09:00
Campbell Barton
3c28eecb6e Fix T41862: Autosmooth & multi-material glitch 2014-09-18 14:55:33 +10:00
Campbell Barton
87208fa699 Fix for edge-order flipping on subdividing wire
Extruding a subdivided edge would create flipped faces.
2014-09-18 13:39:10 +10:00
Campbell Barton
7e0a3baedc Fix T41861: Loopcut wire incorrect mode-switch
also didn't preview or select correctly.
2014-09-18 13:24:48 +10:00
Campbell Barton
8c3daab298 Cleanup: style, spelling 2014-09-18 09:37:49 +10:00
Antony Riakiotakis
59a38ccc42 Fix T41761, muting not working with texture nodes
This was disabled to fix T41349, however seems that if we don't pass
delegates for muted nodes everything work fine.
2014-09-17 19:05:35 +02:00
Campbell Barton
96ac3c2f7d Text Editor: reload missed adding new-line
Logic for load/reload was duplicated, Fix T28087 missed reload.

De-duplicate, also replace stat -> BLI_stat
2014-09-17 19:32:52 +10:00
Campbell Barton
0e0e528ea4 Cleanup: pep8 2014-09-17 18:36:17 +10:00
Bastien Montagne
c793042577 Fix T41840: bpy.context.object.collision.thickness_inner has no effect on cloth.
Only change the tip to stress that, in fact, cloth sim does not use inner thickness at all,
only outer one, through the Collision modifier, afaik.
2014-09-16 16:50:28 +02:00
Campbell Barton
e6828a71d7 Fix T41850: Knife fails with mesh behind view
Was using first vertex for depth (which could be anywhere),
now use the view-pivot.

was also copying uninitialized vector into knife_find_closest_* return values (confused debugging).
2014-09-17 00:34:48 +10:00
Campbell Barton
ba314683fb Fix T41849: Knife fails with small lens
knife cursor depth could be projected behind the view with a wide angle lens.
2014-09-17 00:34:48 +10:00
Campbell Barton
aba5fc29d5 Math Lib: use higher precision for vector printing
Only use for debugging, where precision is often important.
2014-09-17 00:33:38 +10:00
Bastien Montagne
a41a38d11c Fix part of T41739: Solid 3DView not updating when enabling/disabling nodal material.
There are other similar update issues with mat nodes and solid 3DView, but need agreement
on proposed patch from other devs in this area first!
2014-09-16 16:19:23 +02:00
Bastien Montagne
045b26dbf5 Fix T41843: World preview not updating when changing world.
NC_SCENE | ND_WORLD was not handled by buttons space...
2014-09-16 14:28:44 +02:00
Sergey Sharybin
1e948b251d Fix T41818: Missing refresh on Undo for nodes (mask example)
Added a special notifier now NC_WM|ND_UNDO in order to deal with such cases
and now compositor/image will refresh when undo happens.

There are much more ways to fail compo to update the resul, like undoing
while it's not visible and so, but as mont29 said -- let's at least fix
obvious crap in the workflow.
2014-09-16 14:44:47 +06:00
Campbell Barton
3ac640b19e Fix T41842: Knife edge-snap, incorrect offset 2014-09-16 15:43:57 +10:00
Campbell Barton
775a54485b Math Lib: add mul_v3_project_m4_v3 2014-09-16 15:41:17 +10:00
Campbell Barton
106ea0b20b Cleanup: sync map_to_sphere, UNLIKELY xy zero case 2014-09-16 12:41:16 +10:00
Campbell Barton
ece902ed9b Correct invalid sizeof in memset use 2014-09-14 18:50:59 +10:00
Campbell Barton
58305c9403 Sculpt: check mask is present before reading 2014-09-14 17:46:48 +10:00
Campbell Barton
a319469260 Correct last commit 2014-09-14 17:42:33 +10:00
Campbell Barton
432d274990 Cleanup & typo in assignment 2014-09-14 17:27:31 +10:00
Bastien Montagne
fdb12ff564 Fix T41811: unreachable code in wm_keymap.c
There was also an issue with passing sl->spacetype here, for some reason...
2014-09-13 15:49:53 +02:00
Tamito Kajiyama
e5b2e9cdd3 Fix T41800: Freestyle + Cycles panoramic camera not compatible, renders are incorrect. 2014-09-13 11:40:08 +09:00
Campbell Barton
26e476b7e1 Fix T41788: bmesh.utils.loop_separate, face_vert_separate() always return None 2014-09-12 10:16:50 +10:00
Campbell Barton
194f7f0ae8 Cleanup & remove redundant check 2014-09-12 09:53:31 +10:00
Antony Riakiotakis
72d6f254a9 Fix related to T41780, sequencer weirdness with alpha under effect
Fix alpha under equation according to porter-duff and user docs that
state that effect should invert he order of channels and reduce to alpha
over when factor is 1.0.

BTW, we don't really expose any factor here...lost feature from 2.49?
2014-09-11 20:16:12 +02:00
Sergey Sharybin
d919218482 Tracking: Fix wrong behavior of refining with previous frame matching 2014-09-11 20:43:41 +06:00
Sergey Sharybin
b762cc28ea Workaround for strict flags and release build compilation
@campbellbarton, it's really helpful to have strict flags enabled
for release builds as well -- especially when you're working in areas
which are heavily using least squares solvers.

For now made it so blender compiles, but it could be better solution here.
2014-09-11 19:33:37 +06:00
Sergey Sharybin
ed6942f9ad Fix wrong area of interest for movie undistortion 2014-09-11 19:33:01 +06:00
Sergey Sharybin
4bbe0c8cde Fix T41785: The combination of movie-distortion and lens-distortion leads to artifacts 2014-09-11 19:07:20 +06:00
Campbell Barton
149ca1320b Fix non-deterministic editmesh normal orientations
- selecting a boundary edge would randomly point in/outside the face (now point away).
- selecting 3 verts would use the first selected edge as the tangent (now use longest).
- selecting 1 vert betweem edges, uses the edges to define the tangent.
2014-09-11 18:31:02 +10:00
Tamito Kajiyama
507af00855 Freestyle: Fix for missing quality control on line rendering in Cycles.
Freestyle was using the default Cycles rendering settings (e.g., the number
of samples) and users could not change them.  Now all render parameters
(except for film_transparent) are inherited for Freestyle stroke rendering.

Problem report by Danny Grimm on Facebook, thanks!
2014-09-11 13:41:14 +09:00
Campbell Barton
7aedfd654b Fix T41778: Crash on animate boids xith a goal
No need to copy/restore entire object struct (just to read location)
2014-09-11 12:49:46 +10:00
Campbell Barton
bae66459df Fix crash in BLI_kdtree_range_search
Called memcpy with a NULL pointer,
causing the following NULL check to get optimized away.
2014-09-11 12:47:52 +10:00
Campbell Barton
229c2c14f7 Fix crash in project-from view without a brush or active object 2014-09-10 23:12:11 +10:00
Campbell Barton
7d9760d962 Text3d: assert for <0 len text
also add operator to test blacklist
2014-09-10 23:12:11 +10:00
Campbell Barton
3ad9027648 Text3D: fixes to selection
- clamp selection on entering editmode (Python may have changed).
- BKE_vfont_select_get no longer succeeds with an empty selection
  this caused many operators to go ahead and operate on zero size array.
2014-09-10 23:00:24 +10:00
Campbell Barton
64e955f522 Fix crash in active_paint_texture_index callback 2014-09-10 23:00:24 +10:00
Bastien Montagne
20d6b792a4 Fix T41767: Memory free problem when console area copy fail.
Nice little memleak!

Patch by reporter (randon (Dun Liang)) with minor own cleanup, thanks!
2014-09-10 13:14:29 +02:00
Bastien Montagne
965205d0e2 Fix two bugs with searchbox UI items.
First one, reported by Sergey, was searchbox not closing when validating it (enter or LMB click)
without any active item (we need to enable escapecancel here, to close menu too).

Second one was SEARCH_MENU_UNLINK variant not unlinking at validation when no active item.

Thanks a bunch to Campbell for help here!
2014-09-10 12:53:22 +02:00
Anthony Edlin
1811ffff5d Fix T41112: Rotate manipulator (Trackball) + release confirm not working?
Usual same issue (unset property != set property to default value).

Review and minor edits by mont29 (Bastien Montagne).
2014-09-10 12:06:22 +02:00
Campbell Barton
9871788a15 UI: Disable operator search menu setting an unset state key key-input 2014-09-10 19:22:29 +10:00
Campbell Barton
6480fdcae4 Cancel edge-rip macro if no changes are made. 2014-09-10 16:20:08 +10:00