Sergey Sharybin
f3f79ef4bd
Merge branch 'blender-v4.1-release'
2024-03-15 09:53:25 +01:00
Alaska
7ec0ebf30c
Cycles: Fix grammar issues in OIDN GPU command line reporting
...
Pull Request: https://projects.blender.org/blender/blender/pulls/119492
2024-03-15 09:52:47 +01:00
Brecht Van Lommel
335ff6efab
Cycles: Disable OpenImageDenoise support for AMD GPUs in Blender 4.1
...
In older drivers with an integrated GPU, this may crash. This not only
affects HIP, but also can crash when using Cycles with an NVIDIA or
Intel GPU in combination with an AMD CPU.
Fixes for this are expected to be coming, but there will not be enough
time for user testing, and it is difficult to be certain that the fix
is complete.
So to be careful, this is postponed until it has had more testing.
Pull Request: https://projects.blender.org/blender/blender/pulls/119476
2024-03-14 18:18:18 +01:00
Campbell Barton
fc13d2c165
Cleanup: format
2024-03-12 20:56:48 +11:00
Campbell Barton
fff99c2e62
Merge branch 'blender-v4.1-release'
2024-03-12 17:08:53 +11:00
Campbell Barton
dd42a9718d
Cleanup: format
2024-03-12 17:08:29 +11:00
Jacques Lucke
deb332601c
Fix #113090 , #111450 , #104909 : node rna properties collide with built-in names
...
This fixes the following name collisions:
* Compositor Box/Ellipse Mask node: `width` -> `mask_width`
(also renamed the `height` property accordingly)
* Shader AOV Output node: `name` -> `aov_name`
* Geometry Color node: `color` -> `value`.
Those are breaking changes unfortunately, because looking up those property
names yielded the node-specific and not the common property. Therefore, this is
targeted at `main` instead of `4.1`.
Pull Request: https://projects.blender.org/blender/blender/pulls/119284
2024-03-11 15:57:30 +01:00
Brecht Van Lommel
92f6ba5a5f
Merge branch 'blender-v4.1-release'
2024-03-11 15:09:55 +01:00
Brecht Van Lommel
c388ed1e53
Fix #118709 : Crash in OIDN GPU detection for unsupported HIP device
...
Pull Request: https://projects.blender.org/blender/blender/pulls/119315
2024-03-11 15:09:24 +01:00
Brecht Van Lommel
9d0f49c843
Merge branch 'blender-v4.1-release'
2024-03-11 13:11:36 +01:00
Brecht Van Lommel
f7a071bd60
Fix: Build failing when WITH_OPENIMAGEDENOISE is OFF
2024-03-11 12:59:46 +01:00
Alaska
989e9ef890
Fix: Assert in Cycles multi-device OIDN check
...
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Pull Request: https://projects.blender.org/blender/blender/pulls/119267
2024-03-11 12:54:45 +01:00
Miguel Pozo
a53e8d6d24
Merge branch 'blender-v4.1-release'
2024-03-11 12:27:39 +01:00
Attila Afra
60e8b56bcd
Fix: CUDA module memory leak since using primary context
...
Previously the CUDA context was always destroyed and the module along
with it. Now that this no longer happens, the missing module free became
a memory leak.
Also fix the same issue for HIP, though this is destroying the context
so it's not a problem yet.
Fix part of #119035
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2024-03-11 10:39:24 +01:00
Jacques Lucke
2c5f51e683
Merge branch 'blender-v4.1-release'
2024-03-10 14:04:35 +01:00
Campbell Barton
e33f5e36ac
Cleanup: spacing around C-style comment blocks
2024-03-09 23:40:57 +11:00
Brecht Van Lommel
0f1e93e78a
Cleanup: Remove debug print
2024-03-09 12:27:16 +01:00
Hans Goudey
2d3d8c80c3
Cleanup: Make format
2024-03-08 18:29:11 -05:00
Brecht Van Lommel
2e8e2be0af
Merge branch 'blender-v4.1-release'
2024-03-08 22:55:42 +01:00
Brecht Van Lommel
9bebd39197
Cycles: Default to OIDN for NVIDIA in the viewport
...
For consistency across GPU devices, and between viewport and final
render.
Pull Request: https://projects.blender.org/blender/blender/pulls/119213
2024-03-08 22:52:36 +01:00
Brecht Van Lommel
f278e4138c
Fix #118016 : OpenImageDenoise not using GPU for CPU + GPU render
...
Thanks to Alaska for pointing out the cause of the problem.
2024-03-08 22:52:35 +01:00
Hans Goudey
04a9790035
Merge branch 'blender-v4.1-release'
2024-03-08 16:35:33 -05:00
Brecht Van Lommel
898187cfab
Fix #118466 : Cycles renders black on Metal + AMD
...
Global built-ins appear to not work on AMD cards.
Also add a tweak to avoid a performance regression, similar
to what was done before. Disable adaptive subdivision kernel
code if not used.
Pull Request: https://projects.blender.org/blender/blender/pulls/119175
2024-03-08 16:41:27 +01:00
Alaska
2a18bbbdbc
Fix #119141 : Cycles Metal compilation errors
...
Correct order for alignment attribute.
Pull Request: https://projects.blender.org/blender/blender/pulls/119148
2024-03-07 11:41:37 +01:00
Sergey Sharybin
032a24d8ac
Fix Cycles compilation error with OIDN < 2.2
...
The enumerator values for various GPU compute platforms were
added starting with OIDN 2.0, with the Metal GPU type added
in OIDN 2.2.
This is an alternative fix to ebb781675d , which does not lead to
unhandled cases in switch statement, and follows the configuration
of OIDN and not Cycles (as OIDN might report devices which are
disabled in local Cycles build).
Pull Request: https://projects.blender.org/blender/blender/pulls/119155
2024-03-07 11:13:41 +01:00
Campbell Barton
0cd414120b
Unbreak build on macOS with AppleClang from recent cleanup
...
Exact an exact match with Clang broke building when the compiler ID
was "AppleClang", reverting parts of [0].
[0]: 6549019ae1
2024-03-07 19:56:58 +11:00
Campbell Barton
6549019ae1
Cleanup: use STREQUAL instead of MATCHES for exact comparisons
...
MATCHES takes a REGEX and searches the input for a match,
this isn't necessary for CMAKE_SYSTEM_PROCESSOR & CMAKE_*_COMPILER_ID.
2024-03-07 17:56:41 +11:00
Campbell Barton
a975c7096a
Cleanup: line length in CMake files
2024-03-07 13:26:55 +11:00
Sebastian Parborg
ebb781675d
Fix: Add missing ifdef guards for OIDN GPU devices
...
It is not guaranteed that the GPU variables will be available depending
on the current OIDN configuration
2024-03-06 19:19:23 +01:00
Anthony Roberts
3d5fa7698f
Cycles: Add Windows ARM64 support
...
Ref #119126
Pull Request: https://projects.blender.org/blender/blender/pulls/117036
2024-03-06 16:14:34 +01:00
Sergey Sharybin
d88686fb2b
Cycles: Add debug logging to the OIDN GPU checks
...
No functional changes, just something that could help troubleshooting
cases when option to use GPU for denoising is grayed out.
Pull Request: https://projects.blender.org/blender/blender/pulls/119123
2024-03-06 14:54:19 +01:00
Brecht Van Lommel
44d418143e
Merge branch 'blender-v4.1-release'
2024-03-05 19:55:07 +01:00
Sahar A. Kashi
3e09fbf062
Fix #112983 : Cycles HIP-RT crash on deleting all objects
...
Pull Request: https://projects.blender.org/blender/blender/pulls/118944
2024-03-05 19:52:58 +01:00
Lukas Stockner
14a8149318
Cleanup: Cycles: Remove unused function
2024-03-02 02:16:54 +01:00
Brecht Van Lommel
6788b7e87f
Merge branch 'blender-v4.1-release'
2024-02-29 17:55:37 +01:00
Brecht Van Lommel
36c11ee482
Fix #118514 : Cycles MetalRT crash with empty scene
...
Pull Request: https://projects.blender.org/blender/blender/pulls/118907
2024-02-29 17:28:13 +01:00
Brecht Van Lommel
1355285c0e
Merge branch 'blender-v4.1-release'
2024-02-29 13:52:19 +01:00
Brecht Van Lommel
1e44d811ac
Fix #117485 : Crash rendering motion blur with changing curve count
...
This is not supported so there can be artifacts, but it should not
crash.
Pull Request: https://projects.blender.org/blender/blender/pulls/118859
2024-02-29 13:49:51 +01:00
Alaska
659f05ef28
Fix: Cycles HIP incorrect rendering of clip image textures
...
This was fixed in the driver quite a while ago:
https://github.com/ROCm/HIP/pull/2229
Ref: #91571
Pull Request: https://projects.blender.org/blender/blender/pulls/118540
2024-02-29 13:49:29 +01:00
Alaska
0a173b942b
Cycles: Improve reporting of HIP texture allocation failures
...
HIP fails to allocate textures, typically when they are too large.
This commit lets the user know what might be causing the issue
rather than providing a confusing internal error message.
Pull Request: https://projects.blender.org/blender/blender/pulls/118239
2024-02-29 13:49:11 +01:00
Xavier Hallade
b8fdef965d
Merge branch 'blender-v4.1-release'
2024-02-28 18:25:21 +01:00
Xavier Hallade
98343c0c17
Build: Upgrade Intel Graphics Compiler to 1.0.15468 on Linux
...
This corresponds the latest stable LTS release:
https://dgpu-docs.intel.com/releases/LTS_803.29_20240131.html
Graphics compiler upgrades require increasing the mininum required
driver (compute-runtime) version to the corresponding one to guarantee
compatibility, which is XX.XX.27642.38 in this release, so we bump this
requirement accordingly.
Fixes #118713
Pull Request: https://projects.blender.org/blender/blender/pulls/118814
2024-02-28 18:24:30 +01:00
Thomas Dinges
2b095c97fa
Cycles: Increase minimum target on x86 to SSE4.2
...
* Compile regular host code with SSE4.2
* Remove the SSE2 kernel, only the SSE4.2 and AVX2 kernel remain
Pull Request: https://projects.blender.org/blender/blender/pulls/118471
2024-02-26 14:49:19 +01:00
Weizhen Huang
95d11b0d33
Fix Cycles area light using MIS when the spread is zero
...
area light with zero spread was introduced in bf18032977 . Such paths can
only be sampled with NEE, so MIS should not be used.
This fixes the discrepancy when Direct Light Sampling is set to MIS or NEE.
Pull Request: #118584
2024-02-23 12:40:48 +01:00
Weizhen Huang
c292d4dbee
Fix assigning value to nullptr
2024-02-23 12:29:39 +01:00
Weizhen Huang
63dd44c810
Cleanup: avoid implicit conversion from int to float
2024-02-23 12:28:46 +01:00
Weizhen Huang
92c4a5fa09
Fix Principled Hair Huang wrong TIR condition
...
`cos_theta_t` was not initialized for TIR case
Thanks Christophe Hery for spotting the bug
2024-02-23 12:28:23 +01:00
Weizhen Huang
65d910aef7
Fix wrong roughness in Principled Hair Huang trrt+ component
2024-02-23 12:28:08 +01:00
Brecht Van Lommel
b0b1c55a49
Merge branch 'blender-v4.1-release'
2024-02-22 19:08:48 +01:00
Alaska
56bfd56735
Fix: Cycles incorrect rendering of certain negative strength lights
...
This fixes an issue where lights that make use of constant negative strength
emission shaders would render with the absolute of their strength.
Pull Request: https://projects.blender.org/blender/blender/pulls/118541
2024-02-22 19:06:22 +01:00