02a488d0fe
The original bug report was that the Glossy Toon BSDF behaves incorrectly when mixed with other closures. The underlying issue here was that the eval function didn't check whether the reflection angle is inside the valid cone and always returned its PDF, which is very high compared to e.g. the diffuse closure's PDF for small sizes (since the cone is supposed to be quite tight) and therefore breaks MIS mixing. However, while looking into this, I found a number of other issues, and so this commit also contains several other changes to the Toon BSDFs: - The angle that was used to compute the intensity wasn't the actual angle between the vectors. From what I can see, the formula that was used goes back all the way to the initial commit 12 years ago, so this probably was something that happened to work with one particular cone sampling method. Now, however, it caused weird asymmetric highlights, so replace it with the actual angle (which we already compute anyways). - Setting size to zero caused the BSDF to go black, so clamp to 1e-5. - The code was overall a bit repetitive, so I've cleaned it up a bit.
Blender
Blender is the free and open source 3D creation suite. It supports the entirety of the 3D pipeline-modeling, rigging, animation, simulation, rendering, compositing, motion tracking and video editing.
Project Pages
Development
License
Blender as a whole is licensed under the GNU General Public License, Version 3. Individual files may have a different, but compatible license.
See blender.org/about/license for details.