7494a57b16
... if "Only Show Selected Keyframes Handles" is turned ON The piece of code fromfa24ad1fd5-- and that copied from233c650d55-- which alters `incl_handles` for Circle/Lasso is outdated... Atm. it would set `incl_handles` to `false` as soon as either "Show Handles" is OFF or "Only Show Selected Keyframes Handles" is ON. So bug-symptoms would be: - turn ON both "Show Handles" and "Only Show Selected Keyframes Handles" - select a single keyframe (so its handles are visible) - try to select that handle using Circle/Lasso - fail - (alternatively: select the key using Circle/Lasso >> handles get selected as well, also a fail) Inb037ba2665though we introduced `KEYFRAME_ITER_HANDLES_DEFAULT_INVISIBLE` in which can properly handle such cases in `keyframe_ok_checks` / `select_bezier_add` / `select_bezier_subtract`, so it makes sense to only check for "Show Handles" Circle/Lasso and let `initialize_box_select_key_editing_data` / `keyframe_ok_checks` / `select_bezier_add` / `select_bezier_subtract` handle the rest... Noticed while doing !139349, part of #139314 Pull Request: https://projects.blender.org/blender/blender/pulls/139531
Blender
Blender is the free and open source 3D creation suite. It supports the entirety of the 3D pipeline—modeling, rigging, animation, simulation, rendering, compositing, motion tracking and video editing.
Project Pages
Development
License
Blender as a whole is licensed under the GNU General Public License, Version 3. Individual files may have a different but compatible license.
See blender.org/about/license for details.