3c70758f00
A couple of memory leak fixes for the vulkan backend. We increment the submission_id on render_graphs upon reset. This triggers cleanup of anything tracked as a VKResourceTracker. Notably uniform buffers created for push constant fallbacks. This fixes a memory leak that was accumulating VKUniformBuffers every frame without cleaning them up. Reset resource pools when a swapchain image is presented. This ends up calling vkResetDescriptorPool, freeing up descriptor set resources. This fixes a memory leak that was accumulate descriptor sets and pools over time without freeing them. Pull Request: https://projects.blender.org/blender/blender/pulls/137305
107 lines
2.4 KiB
C++
107 lines
2.4 KiB
C++
/* SPDX-FileCopyrightText: 2024 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#include "vk_render_graph.hh"
|
|
#include "gpu_backend.hh"
|
|
|
|
#include <sstream>
|
|
|
|
namespace blender::gpu::render_graph {
|
|
|
|
VKRenderGraph::VKRenderGraph(VKResourceStateTracker &resources) : resources_(resources)
|
|
{
|
|
submission_id.reset();
|
|
}
|
|
|
|
void VKRenderGraph::reset()
|
|
{
|
|
submission_id.next();
|
|
|
|
links_.clear();
|
|
for (VKRenderGraphNode &node : nodes_) {
|
|
node.free_data(storage_);
|
|
}
|
|
nodes_.clear();
|
|
storage_.reset();
|
|
|
|
debug_.node_group_map.clear();
|
|
debug_.used_groups.clear();
|
|
debug_.group_stack.clear();
|
|
debug_.groups.clear();
|
|
}
|
|
|
|
/** \} */
|
|
|
|
/* -------------------------------------------------------------------- */
|
|
/** \name Debug
|
|
* \{ */
|
|
|
|
void VKRenderGraph::debug_group_begin(const char *name, const ColorTheme4f &color)
|
|
{
|
|
ColorTheme4f useColor = color;
|
|
if ((color == blender::gpu::debug::GPU_DEBUG_GROUP_COLOR_DEFAULT) &&
|
|
(debug_.group_stack.size() > 0))
|
|
{
|
|
useColor = debug_.groups[debug_.group_stack.last()].color;
|
|
}
|
|
DebugGroupNameID name_id = debug_.groups.index_of_or_add({std::string(name), useColor});
|
|
debug_.group_stack.append(name_id);
|
|
debug_.group_used = false;
|
|
}
|
|
|
|
void VKRenderGraph::debug_group_end()
|
|
{
|
|
debug_.group_stack.pop_last();
|
|
debug_.group_used = false;
|
|
}
|
|
|
|
void VKRenderGraph::debug_print(NodeHandle node_handle) const
|
|
{
|
|
std::ostream &os = std::cout;
|
|
os << "NODE:\n";
|
|
const VKRenderGraphNode &node = nodes_[node_handle];
|
|
os << " type:" << node.type << "\n";
|
|
|
|
const VKRenderGraphNodeLinks &links = links_[node_handle];
|
|
os << " inputs:\n";
|
|
for (const VKRenderGraphLink &link : links.inputs) {
|
|
os << " ";
|
|
link.debug_print(os, resources_);
|
|
os << "\n";
|
|
}
|
|
os << " outputs:\n";
|
|
for (const VKRenderGraphLink &link : links.outputs) {
|
|
os << " ";
|
|
link.debug_print(os, resources_);
|
|
os << "\n";
|
|
}
|
|
}
|
|
|
|
std::string VKRenderGraph::full_debug_group(NodeHandle node_handle) const
|
|
{
|
|
if ((G.debug & G_DEBUG_GPU) == 0) {
|
|
return std::string();
|
|
}
|
|
|
|
DebugGroupID debug_group = debug_.node_group_map[node_handle];
|
|
if (debug_group == -1) {
|
|
return std::string();
|
|
}
|
|
|
|
std::stringstream ss;
|
|
for (const VKRenderGraph::DebugGroupNameID &name_id : debug_.used_groups[debug_group]) {
|
|
ss << "/" << debug_.groups[name_id].name;
|
|
}
|
|
|
|
return ss.str();
|
|
}
|
|
|
|
/** \} */
|
|
|
|
} // namespace blender::gpu::render_graph
|