griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: VSE: Possible division by zero in retiming code

Browse Source 
Strips with single frame content could be retimed, which would lead to
division by zero.

Check content length before adding retiming keys.

Pull Request: https://projects.blender.org/blender/blender/pulls/131725
This commit is contained in:
Richard Antalik
2024-12-11 10:29:45 +01:00
committed by Richard Antalik
parent 3e35d411be
commit 0aa653c05c
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/blender/sequencer/intern/strip_retiming.cc
View File

@@ -164,6 +164,10 @@ bool SEQ_retiming_data_is_editable(const Sequence *seq)
bool SEQ_retiming_is_allowed(const Sequence *seq)
{
if (seq->len < 2) {
return false;
}
return ELEM(seq->type,
SEQ_TYPE_SOUND_RAM,
SEQ_TYPE_IMAGE,
@@ -306,6 +310,9 @@ float seq_retiming_evaluate(const Sequence *seq, const float frame_index)
static SeqRetimingKey *seq_retiming_add_key(Sequence *seq, float frame_index)
{
if (!SEQ_retiming_is_allowed(seq)) {
return nullptr;
}
/* Clamp timeline frame to strip content range. */
if (frame_index <= 0) {
return &seq->retiming_keys[0];