griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #137022: EEVEE: Shadows on reflection planes render incorrectly

Browse Source 
This was caused by the cross product changing
sign in view space during planar lightprobe capture.

This can be avoided by making sure the view matrix
doesn't change handedness.

Pull Request: https://projects.blender.org/blender/blender/pulls/137092
This commit is contained in:
Clément Foucault
2025-04-07 16:27:31 +02:00
committed by Clément Foucault
parent 9b1a34e83e
commit 13bf095c18
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/draw/engines/eevee/eevee_lightprobe_planar.cc
View File

@@ -15,7 +15,9 @@ using namespace blender::math;
void PlanarProbe::set_view(const draw::View &view, int layer_id)
{
this->viewmat = view.viewmat() * reflection_matrix_get();
/* Invert the up axis to avoid changing handedness (see #137022). */
this->viewmat = from_scale<float4x4>(float3(1, -1, 1)) * view.viewmat() *
reflection_matrix_get();
this->winmat = view.winmat();
this->world_to_object_transposed = float3x4(transpose(world_to_plane));
this->normal = normalize(plane_to_world.z_axis());

11
source/blender/draw/engines/eevee/shaders/eevee_display_lightprobe_planar_frag.glsl
View File

@@ -9,10 +9,17 @@ FRAGMENT_SHADER_CREATE_INFO(eevee_display_lightprobe_planar)
#include "draw_view_lib.glsl"
#include "eevee_lightprobe_sphere_lib.glsl"
vec2 sampling_uv(vec2 screen_uv)
{
/* Render is inverted in Y. */
screen_uv.y = 1.0 - screen_uv.y;
return screen_uv;
}
void main()
{
vec2 uv = gl_FragCoord.xy / vec2(textureSize(planar_radiance_tx, 0).xy);
float depth = texture(planar_depth_tx, vec3(uv, probe_index)).r;
float depth = texture(planar_depth_tx, vec3(sampling_uv(uv), probe_index)).r;
if (depth == 1.0) {
vec3 ndc = drw_screen_to_ndc(vec3(uv, 0.0));
vec3 wP = drw_point_ndc_to_world(ndc);
@@ -23,7 +30,7 @@ void main()
out_color = lightprobe_spheres_sample(R, 0.0, world_atlas_coord);
}
else {
out_color = texture(planar_radiance_tx, vec3(uv, probe_index));
out_color = texture(planar_radiance_tx, vec3(sampling_uv(uv), probe_index));
}
out_color.a = 0.0;
}