griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Color Management: fix for view/display settings validation

Browse Source 
It was a misusage of LinkData and actual data leading to wrong
string comparsion and possible wrong memory access.
This commit is contained in:
Sergey Sharybin
2012-09-04 12:32:18 +00:00
parent 3b9c3604c6
commit 1508f62169
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/imbuf/intern/colormanagement.c
View File

@@ -1453,17 +1453,20 @@ void IMB_colormanagement_validate_settings(ColorManagedDisplaySettings *display_
{
#ifdef WITH_OCIO
ColorManagedDisplay *display;
ColorManagedView *default_view, *view;
ColorManagedView *default_view;
LinkData *view_link;
display = colormanage_display_get_named(display_settings->display_device);
default_view = colormanage_view_get_default(display);
for (view = display->views.first; view; view = view->next) {
for (view_link = display->views.first; view_link; view_link = view_link->next) {
ColorManagedView *view = view_link->data;
if (!strcmp(view->name, view_settings->view_transform))
break;
}
if (view == NULL)
if (view_link == NULL)
BLI_strncpy(view_settings->view_transform, default_view->name, sizeof(view_settings->view_transform));
#else
(void) display_settings;