griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Outliner: Fix memory errors in runtime data

Browse Source 
Fix a heap-use-after-free when duplicating outliner editors, and fully
free runtime data when freeing outliner editors.
This commit is contained in:
Nathan Craddock
2020-11-14 14:09:53 -07:00
parent 6ac5e0b3e8
commit 194a57fd63
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/space_outliner/space_outliner.c
View File

@@ -53,6 +53,7 @@
#include "GPU_framebuffer.h"
#include "outliner_intern.h"
#include "tree/tree_display.h"
static void outliner_main_region_init(wmWindowManager *wm, ARegion *region)
{
@@ -353,6 +354,7 @@ static void outliner_free(SpaceLink *sl)
}
if (space_outliner->runtime) {
outliner_tree_display_destroy(&space_outliner->runtime->tree_display);
MEM_freeN(space_outliner->runtime);
}
}
@@ -381,6 +383,7 @@ static SpaceLink *outliner_duplicate(SpaceLink *sl)
if (space_outliner->runtime) {
space_outliner_new->runtime = MEM_dupallocN(space_outliner->runtime);
space_outliner_new->runtime->tree_display = NULL;
}
return (SpaceLink *)space_outliner_new;