griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Don't draw spans for out of bounds retiming keys in the VSE

Browse Source 
Previously the spans would be drawn even if you had slid the retiming
keys out of bounds of the strip margins, leading to them being drawn out
side of the strip.

Pull Request: https://projects.blender.org/blender/blender/pulls/123438
This commit is contained in:
Sebastian Parborg
2024-07-12 15:35:40 +02:00
committed by Gitea
parent 20641b81bc
commit 1eaa47c215
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/editors/space_sequencer/sequencer_retiming_draw.cc
View File

@@ -320,6 +320,14 @@ void sequencer_retiming_draw_continuity(const TimelineDrawContext *timeline_ctx,
float key_position = UI_view2d_view_to_region_x(v2d, key_x_get(scene, seq, &key));
float prev_key_position = UI_view2d_view_to_region_x(v2d, key_x_get(scene, seq, &key - 1));
if (prev_key_position > right_handle_position) {
/* Don't draw highlights for out of bounds retiming keys. */
continue;
}
if (key_position < left_handle_position) {
/* Don't draw highlights for out of bounds retiming keys. */
continue;
}
prev_key_position = max_ff(prev_key_position, left_handle_position);
key_position = min_ff(key_position, right_handle_position);