Vulkan: Only select HDR swapchain on Wayland

Half float swapchains were selected even on platforms that are not able
to use HDR. This PR will limit the creation of HDR swapchains only to
Wayland.

Pull Request: https://projects.blender.org/blender/blender/pulls/141650

intern/ghost/intern/GHOST_ContextVK.cc

@@ -633,7 +633,7 @@ GHOST_TSuccess GHOST_ContextVK::swapBuffers()
   VkFence *next_frame_fence = &m_frame_data[next_render_frame].submission_fence;
   vkWaitForFences(device, 1, next_frame_fence, true, UINT64_MAX);
   submission_frame_data.discard_pile.destroy(device);
-
+  bool use_hdr_swapchain = false;
 #ifdef WITH_GHOST_WAYLAND
   /* Wayland doesn't provide a WSI with windowing capabilities, therefore cannot detect whether the
    * swap-chain needs to be recreated. But as a side effect we can recreate the swap chain before
@@ -644,10 +644,11 @@ GHOST_TSuccess GHOST_ContextVK::swapBuffers()
           std::max(m_render_extent.width, m_render_extent_min.width)) ||
          (m_wayland_window_info->size[1] !=
           std::max(m_render_extent.height, m_render_extent_min.height)));
+    use_hdr_swapchain = m_wayland_window_info->is_color_managed;
 
     if (recreate_swapchain) {
       /* Swap-chain is out of date. Recreate swap-chain. */
-      recreateSwapchain();
+      recreateSwapchain(use_hdr_swapchain);
     }
   }
 #endif
@@ -664,7 +665,7 @@ GHOST_TSuccess GHOST_ContextVK::swapBuffers()
                                            VK_NULL_HANDLE,
                                            &image_index);
     if (acquire_result == VK_ERROR_OUT_OF_DATE_KHR || acquire_result == VK_SUBOPTIMAL_KHR) {
-      recreateSwapchain();
+      recreateSwapchain(use_hdr_swapchain);
     }
   }
   CLOG_INFO(&LOG, 3, "render_frame=%lu, image_index=%u", m_render_frame, image_index);
@@ -699,7 +700,7 @@ GHOST_TSuccess GHOST_ContextVK::swapBuffers()
   }
   m_render_frame = next_render_frame;
   if (present_result == VK_ERROR_OUT_OF_DATE_KHR || present_result == VK_SUBOPTIMAL_KHR) {
-    recreateSwapchain();
+    recreateSwapchain(use_hdr_swapchain);
     if (swap_buffers_post_callback_) {
       swap_buffers_post_callback_();
     }
@@ -845,6 +846,7 @@ static GHOST_TSuccess selectPresentMode(VkPhysicalDevice device,
  */
 static bool selectSurfaceFormat(const VkPhysicalDevice physical_device,
                                 const VkSurfaceKHR surface,
+                                bool use_hdr_swapchain,
                                 VkSurfaceFormatKHR &r_surfaceFormat)
 {
   uint32_t format_count;
@@ -860,6 +862,9 @@ static bool selectSurfaceFormat(const VkPhysicalDevice physical_device,
   };
 
   for (pair<VkColorSpaceKHR, VkFormat> &pair : selection_order) {
+    if (pair.second == VK_FORMAT_R16G16B16A16_SFLOAT && !use_hdr_swapchain) {
+      continue;
+    }
     for (const VkSurfaceFormatKHR &format : formats) {
       if (format.colorSpace == pair.first && format.format == pair.second) {
         r_surfaceFormat = format;
@@ -904,14 +909,14 @@ GHOST_TSuccess GHOST_ContextVK::initializeFrameData()
   return GHOST_kSuccess;
 }
 
-GHOST_TSuccess GHOST_ContextVK::recreateSwapchain()
+GHOST_TSuccess GHOST_ContextVK::recreateSwapchain(bool use_hdr_swapchain)
 {
   assert(vulkan_device.has_value() && vulkan_device->device != VK_NULL_HANDLE);
 
   VkPhysicalDevice physical_device = vulkan_device->physical_device;
 
   m_surface_format = {};
-  if (!selectSurfaceFormat(physical_device, m_surface, m_surface_format)) {
+  if (!selectSurfaceFormat(physical_device, m_surface, use_hdr_swapchain, m_surface_format)) {
     return GHOST_kFailure;
   }
 
@@ -1163,6 +1168,7 @@ const char *GHOST_ContextVK::getPlatformSpecificSurfaceExtension() const
 
 GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
 {
+  bool use_hdr_swapchain = false;
 #ifdef _WIN32
   const bool use_window_surface = (m_hwnd != nullptr);
 #elif defined(__APPLE__)
@@ -1178,6 +1184,9 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
 #  ifdef WITH_GHOST_WAYLAND
     case GHOST_kVulkanPlatformWayland:
       use_window_surface = (m_wayland_display != nullptr) && (m_wayland_surface != nullptr);
+      if (m_wayland_window_info) {
+        use_hdr_swapchain = m_wayland_window_info->is_color_managed;
+      }
       break;
 #  endif
     case GHOST_kVulkanPlatformHeadless:
@@ -1327,7 +1336,7 @@ GHOST_TSuccess GHOST_ContextVK::initializeDrawingContext()
   if (use_window_surface) {
     vkGetDeviceQueue(
         vulkan_device->device, vulkan_device->generic_queue_family, 0, &m_present_queue);
-    recreateSwapchain();
+    recreateSwapchain(use_hdr_swapchain);
   }
 
   active_context_ = this;

intern/ghost/intern/GHOST_ContextVK.hh

@@ -56,6 +56,7 @@ enum GHOST_TVulkanPlatformType {
 
 struct GHOST_ContextVK_WindowInfo {
   int size[2];
+  bool is_color_managed;
 };
 
 struct GHOST_FrameDiscard {
@@ -252,7 +253,7 @@ class GHOST_ContextVK : public GHOST_Context {
   std::function<void(GHOST_VulkanOpenXRData *)> openxr_release_framebuffer_image_callback_;
 
   const char *getPlatformSpecificSurfaceExtension() const;
-  GHOST_TSuccess recreateSwapchain();
+  GHOST_TSuccess recreateSwapchain(bool use_hdr_swapchain);
   GHOST_TSuccess initializeFrameData();
   GHOST_TSuccess destroySwapchain();
 };

intern/ghost/intern/GHOST_WindowWayland.cc

@@ -2026,6 +2026,7 @@ GHOST_WindowWayland::GHOST_WindowWayland(GHOST_SystemWayland *system,
     window_->backend.vulkan_window_info = new GHOST_ContextVK_WindowInfo;
     window_->backend.vulkan_window_info->size[0] = window_->frame.size[0];
     window_->backend.vulkan_window_info->size[1] = window_->frame.size[1];
+    window_->backend.vulkan_window_info->is_color_managed = true;
   }
 #endif