griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor: remove unused function

Browse Source 
this patch just removes an unused function left behind by #132601

Pull Request: https://projects.blender.org/blender/blender/pulls/133162
This commit is contained in:
Christoph Lendenfeld
2025-01-16 17:02:12 +01:00
committed by Christoph Lendenfeld
parent dbb81ca483
commit 3fca91ad74
3 changed files with 0 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/animrig/ANIM_pose.hh
View File

@@ -19,14 +19,6 @@ struct bAction;
namespace blender::animrig {
/**
* Evaluate the action and apply it to the pose. Only FCurves that
* relate to selected bones are evaluated.
*/
void pose_apply_action_selected_bones(Object *ob,
bAction *action,
slot_handle_t slot_handle,
const AnimationEvalContext *anim_eval_context);
/**
* Evaluate the action and apply it to the pose. Ignore selection state of the bones.
*/

15
source/blender/animrig/intern/pose.cc
View File

@@ -86,21 +86,6 @@ void pose_apply(Object *ob,
} // namespace
void pose_apply_action_selected_bones(Object *ob,
bAction *action,
const int32_t slot_handle,
const AnimationEvalContext *anim_eval_context)
{
auto evaluate_and_apply = [](PointerRNA *ptr,
bAction *act,
const int32_t slot_handle,
const AnimationEvalContext *anim_eval_context) {
animsys_evaluate_action(ptr, act, slot_handle, anim_eval_context, false);
};
pose_apply(ob, action, slot_handle, anim_eval_context, evaluate_and_apply);
}
void pose_apply_action_all_bones(Object *ob,
bAction *action,
const int32_t slot_handle,

30
source/blender/animrig/intern/pose_test.cc
View File

@@ -193,36 +193,6 @@ TEST_F(PoseTest, apply_action_all_bones_multiple_slots)
<< "Applying the same pose should result in the same values.";
}
TEST_F(PoseTest, apply_action_selected_bones_single_slot)
{
Slot &first_slot = pose_action->slot_add();
keyframe_data->keyframe_insert(
bmain, first_slot, {"pose.bones[\"BoneA\"].location", 0}, {1, 10}, key_settings);
keyframe_data->keyframe_insert(
bmain, first_slot, {"pose.bones[\"BoneB\"].location", 1}, {1, 5}, key_settings);
bPoseChannel *bone_a = BKE_pose_channel_find_name(obj_armature_a->pose, "BoneA");
bPoseChannel *bone_b = BKE_pose_channel_find_name(obj_armature_a->pose, "BoneB");
bone_a->loc[1] = 1.0;
bone_a->loc[2] = 2.0;
bone_b->loc[1] = 0.0;
/* The algorithm code uses the bone flag instead of the pose bone flag. */
bone_a->bone->flag |= BONE_SELECTED;
bone_b->bone->flag &= ~BONE_SELECTED;
AnimationEvalContext eval_context = {nullptr, 1.0f};
blender::animrig::pose_apply_action_selected_bones(
obj_armature_a, pose_action, first_slot.handle, &eval_context);
EXPECT_EQ(bone_a->loc[0], 10.0);
EXPECT_EQ(bone_b->loc[1], 0.0) << "Unselected bones should not be affected.";
EXPECT_EQ(bone_a->loc[1], 1.0) << msg_unexpected_modification;
EXPECT_EQ(bone_a->loc[2], 2.0) << msg_unexpected_modification;
}
TEST_F(PoseTest, apply_action_blend_single_slot)
{
Slot &first_slot = pose_action->slot_add();