griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #108571: OBJ vertex group import crash

Browse Source 
`tot_loop_idx` was increased before it was used to set the set
the vertex group value of the current face corner's vertex.
This commit is contained in:
Hans Goudey
2023-06-05 20:20:03 -04:00
parent 7e7c14ad4c
commit 41d994c9ac
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
source/blender/io/wavefront_obj/importer/obj_import_mesh.cc
View File

@@ -215,19 +215,19 @@ void MeshFromGeometry::create_polys_loops(Mesh *mesh, bool use_vertex_groups)
const PolyCorner &curr_corner = mesh_geometry_.face_corners_[curr_face.start_index_ + idx];
corner_verts[tot_loop_idx] = mesh_geometry_.global_to_local_vertices_.lookup_default(
curr_corner.vert_index, 0);
tot_loop_idx++;
/* Setup vertex group data, if needed. */
if (dverts.is_empty()) {
continue;
}
const int group_index = curr_face.vertex_group_index;
/* Note: face might not belong to any group */
if (group_index >= 0 || 1) {
MDeformWeight *dw = BKE_defvert_ensure_index(&dverts[corner_verts[tot_loop_idx]],
group_index);
dw->weight = 1.0f;
if (!dverts.is_empty()) {
const int group_index = curr_face.vertex_group_index;
/* Note: face might not belong to any group */
if (group_index >= 0 || 1) {
MDeformWeight *dw = BKE_defvert_ensure_index(&dverts[corner_verts[tot_loop_idx]],
group_index);
dw->weight = 1.0f;
}
}
tot_loop_idx++;
}
}