griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #139553: EEVEE: Vulkan raytracing denoising pink propagation

Browse Source 
This was caused by precision issue that made `sqrt(1.0f - NV2)`
evaluate to NaN. Making sure the input is saturated fixes the
issue.

Pull Request: https://projects.blender.org/blender/blender/pulls/140071
This commit is contained in:
Clément Foucault
2025-06-10 12:37:54 +02:00
committed by Clément Foucault
parent 5d07055b0f
commit 4bee4a456a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/draw/engines/eevee/shaders/eevee_bxdf_microfacet_lib.glsl
View File

@@ -125,8 +125,9 @@ BsdfEval bxdf_ggx_eval_reflection(float3 N, float3 L, float3 V, float alpha, boo
BsdfEval eval;
float NV2 = square(NV);
float s2 = square(1.0f + sqrt(1.0f - NV2));
float len_ai_sqr = a2 * (1.0f - NV2);
float one_minus_NV2 = saturate(1.0f - NV2);
float s2 = square(1.0f + sqrt(one_minus_NV2));
float len_ai_sqr = a2 * one_minus_NV2;
float t = sqrt(len_ai_sqr + NV2);
if (NV >= 0.0f) {
float k = (1.0f - a2) * s2 / (s2 + a2 * NV2);