griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Compositor: Remove unused Defocus node options

Browse Source 
This patch marks the Preview and Threshold options as deprecated and
removes them from the UI. They have been unused since 4.3.
This commit is contained in:
Omar Emara
2025-05-01 15:59:43 +03:00
parent a31dcdf5b5
commit 4d0a70f638
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/makesrna/intern/rna_nodetree.cc
View File

@@ -8575,15 +8575,16 @@ static void def_cmp_defocus(BlenderRNA * /*brna*/, StructRNA *srna)
prop = RNA_def_property(srna, "threshold", PROP_FLOAT, PROP_NONE);
RNA_def_property_float_sdna(prop, nullptr, "bthresh");
RNA_def_property_range(prop, 0.0f, 100.0f);
RNA_def_property_ui_text(
prop,
"Threshold",
"CoC radius threshold, prevents background bleed on in-focus midground, 0 is disabled");
RNA_def_property_ui_text(prop,
"Threshold",
"CoC radius threshold, prevents background bleed on in-focus "
"midground, 0 is disabled. (Deprecated: Unused.)");
RNA_def_property_update(prop, NC_NODE | NA_EDITED, "rna_Node_update");
prop = RNA_def_property(srna, "use_preview", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, nullptr, "preview", 1);
RNA_def_property_ui_text(prop, "Preview", "Enable low quality mode, useful for preview");
RNA_def_property_ui_text(
prop, "Preview", "Enable low quality mode, useful for preview. (Deprecated: Unused.)");
RNA_def_property_update(prop, NC_NODE | NA_EDITED, "rna_Node_update");
prop = RNA_def_property(srna, "use_zbuffer", PROP_BOOLEAN, PROP_NONE);

6
source/blender/nodes/composite/nodes/node_composite_defocus.cc
View File

@@ -50,12 +50,10 @@ static void node_composit_init_defocus(bNodeTree * /*ntree*/, bNode *node)
NodeDefocus *nbd = MEM_callocN<NodeDefocus>(__func__);
nbd->bktype = 0;
nbd->rotation = 0.0f;
nbd->preview = 1;
nbd->gamco = 0;
nbd->samples = 16;
nbd->fstop = 128.0f;
nbd->maxblur = 16;
nbd->bthresh = 1.0f;
nbd->scale = 1.0f;
nbd->no_zbuf = 1;
node->storage = nbd;
@@ -78,10 +76,6 @@ static void node_composit_buts_defocus(uiLayout *layout, bContext *C, PointerRNA
uiItemR(col, ptr, "f_stop", UI_ITEM_R_SPLIT_EMPTY_NAME, std::nullopt, ICON_NONE);
uiItemR(layout, ptr, "blur_max", UI_ITEM_R_SPLIT_EMPTY_NAME, std::nullopt, ICON_NONE);
uiItemR(layout, ptr, "threshold", UI_ITEM_R_SPLIT_EMPTY_NAME, std::nullopt, ICON_NONE);
col = &layout->column(false);
uiItemR(col, ptr, "use_preview", UI_ITEM_R_SPLIT_EMPTY_NAME, std::nullopt, ICON_NONE);
uiTemplateID(layout, C, ptr, "scene", nullptr, nullptr, nullptr);