griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Assert in draw mesh tangents extraction

Browse Source 
Avoid requesting mesh data when the mesh is an edit mesh wrapper. That
triggered asserts that hid the real issue in #136235.
This commit is contained in:
Hans Goudey
2025-03-21 15:00:04 -04:00
parent 485167dd02
commit 4e1e47f840
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc
View File

@@ -56,10 +56,6 @@ static void extract_tan_init_common(const MeshRenderData &mr,
use_orco_tan = false;
}
const Span<int3> corner_tris = mr.mesh->corner_tris();
const Span<int> corner_tri_faces = mr.mesh->corner_tri_faces();
const Span<float3> vert_normals = mr.mesh->vert_normals();
for (int i = 0; i < MAX_MTFACE; i++) {
if (tan_layers & (1 << i)) {
char attr_name[32], attr_safe_name[GPU_MAX_SAFE_ATTR_NAME];
@@ -124,15 +120,15 @@ static void extract_tan_init_common(const MeshRenderData &mr,
BKE_mesh_calc_loop_tangent_ex(mr.vert_positions,
mr.faces,
mr.corner_verts.data(),
corner_tris.data(),
corner_tri_faces.data(),
mr.mesh->corner_tris().data(),
mr.mesh->corner_tri_faces().data(),
mr.corner_tris_num,
mr.sharp_faces,
cd_ldata,
calc_active_tangent,
r_tangent_names,
tan_len,
vert_normals,
mr.mesh->vert_normals(),
mr.face_normals,
mr.corner_normals,
orco,