Fix for a buffer overflow, by simply removing the unnecessary string copy.

Review comment from Campbell.
2013-03-02 18:43:06 +00:00
parent 6645551aed
commit 51460e7789
1 changed files with 1 additions and 2 deletions
--- a/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp
+++ b/source/blender/freestyle/intern/blender_interface/BlenderStrokeRenderer.cpp
@@ -175,8 +175,7 @@ BlenderStrokeRenderer::~BlenderStrokeRenderer()
 	for (Base *b = (Base*)freestyle_scene->base.first; b; b = b->next) {
 		Object *ob = b->object;
 		void *data = ob->data;
-		char name[24];
-		strcpy(name, ob->id.name);
+		char *name = ob->id.name;
 #if 0
 		if (G.debug & G_DEBUG_FREESTYLE) {
 			cout << "removing " << name[0] << name[1] << ":" << (name+2) << endl;