WM: prevent tweaking a gizmo performing an undo push when canceling

Canceling an action should never add an undo step.
2024-08-23 15:06:24 +10:00
parent a4667fbb3d
commit 5387605833
1 changed files with 4 additions and 2 deletions
--- a/source/blender/windowmanager/gizmo/intern/wm_gizmo_group.cc
+++ b/source/blender/windowmanager/gizmo/intern/wm_gizmo_group.cc
@@ -467,8 +467,10 @@ static void gizmo_tweak_finish(bContext *C, wmOperator *op, const bool cancel, b
      wm_gizmomap_modal_set(mtweak->gzmap, C, mtweak->gz_modal, nullptr, false);
    }
  }
-  if (mtweak->gz_modal->flag & WM_GIZMO_NEEDS_UNDO) {
-    ED_undo_push(C, "Gizmo");
+  if (cancel == false) {
+    if (mtweak->gz_modal->flag & WM_GIZMO_NEEDS_UNDO) {
+      ED_undo_push(C, "Gizmo");
+    }
  }
  MEM_freeN(mtweak);
 }