griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Quicktime (non cocoa) crash upon export temporary fix

Browse Source 
Removed the pop up of the codec settings dialog box that was causing the crash, as it was called from the render thread (and not the main one).

So qt export settings are now blocked on default settings:
codec=jpeg, quality=max, bitrate=5MBps

Complete fix will be done by replacing this dialog box by "encoding" settings in the render panel.
This commit is contained in:
Damien Plisson
2009-11-18 16:38:22 +00:00
parent cee7d6ac4c
commit 5a4045ad7d
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/quicktime/apple/quicktime_export.c
View File

@@ -620,12 +620,13 @@ int get_qtcodec_settings(RenderData *rd)
check_renderbutton_framerate(rd);
} else {
// configure the standard image compression dialog box
// set some default settings
// set some default settings: codec=jpeg, quality = max
qtdata->gSpatialSettings.codecType = kJPEGCodecType;
qtdata->gSpatialSettings.codec = anyCodec;
qtdata->gSpatialSettings.spatialQuality = codecMaxQuality;
qtdata->gTemporalSettings.temporalQuality = codecMaxQuality;
qtdata->gTemporalSettings.keyFrameRate = 25;
qtdata->aDataRateSetting.dataRate = 90 * 1024;
qtdata->aDataRateSetting.dataRate = 5 * 1024 * 1024;
err = SCSetInfo(qtdata->theComponent, scTemporalSettingsType, &qtdata->gTemporalSettings);
CheckError(err, "SCSetInfo1 error");
@@ -637,6 +638,8 @@ int get_qtcodec_settings(RenderData *rd)
check_renderbutton_framerate(rd);
/* Remove this dialog box pop up as this function is called from the render thread
Anyway, all config should be done inside blender ui before starting render.
// put up the dialog box - it needs to be called from the main thread
err = SCRequestSequenceSettings(qtdata->theComponent);
@@ -648,7 +651,7 @@ int get_qtcodec_settings(RenderData *rd)
// get user selected data
SCGetInfo(qtdata->theComponent, scTemporalSettingsType, &qtdata->gTemporalSettings);
SCGetInfo(qtdata->theComponent, scSpatialSettingsType, &qtdata->gSpatialSettings);
SCGetInfo(qtdata->theComponent, scDataRateSettingsType, &qtdata->aDataRateSetting);
SCGetInfo(qtdata->theComponent, scDataRateSettingsType, &qtdata->aDataRateSetting);*/
QT_SaveCodecSettingsToScene(rd);