griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #142785: Sculpt mode multires fast navigate artifacts

Browse Source 
Part of the index buffer was uninitialized. Don't upload that part.
Similar to d84f10f2a0.

Pull Request: https://projects.blender.org/blender/blender/pulls/142891
This commit is contained in:
Hans Goudey
2025-07-23 14:38:10 +02:00
committed by Hans Goudey
parent 59625019b8
commit 61cf76071b
1 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
source/blender/draw/intern/draw_pbvh.cc
View File

@@ -1200,12 +1200,12 @@ static gpu::IndexBufPtr create_lines_index_bmesh(const Set<BMFace *, 0> &faces,
return gpu::IndexBufPtr(GPU_indexbuf_build_ex(&builder, 0, visible_faces_num * 3, false));
}
static void create_tri_index_grids(const Span<int> grid_indices,
const BitGroupVector<> &grid_hidden,
const int gridsize,
const int skip,
const int totgrid,
MutableSpan<uint3> data)
static int create_tri_index_grids(const Span<int> grid_indices,
const BitGroupVector<> &grid_hidden,
const int gridsize,
const int skip,
const int totgrid,
MutableSpan<uint3> data)
{
int tri_index = 0;
int offset = 0;
@@ -1235,14 +1235,16 @@ static void create_tri_index_grids(const Span<int> grid_indices,
}
}
}
return tri_index;
}
static void create_tri_index_grids_flat_layout(const Span<int> grid_indices,
const BitGroupVector<> &grid_hidden,
const int gridsize,
const int skip,
const int totgrid,
MutableSpan<uint3> data)
static int create_tri_index_grids_flat_layout(const Span<int> grid_indices,
const BitGroupVector<> &grid_hidden,
const int gridsize,
const int skip,
const int totgrid,
MutableSpan<uint3> data)
{
int tri_index = 0;
int offset = 0;
@@ -1286,6 +1288,7 @@ static void create_tri_index_grids_flat_layout(const Span<int> grid_indices,
}
}
}
return tri_index;
}
static void create_lines_index_grids(const Span<int> grid_indices,
@@ -1570,14 +1573,22 @@ static gpu::IndexBufPtr create_tri_index_grids(const CCGKey &key,
MutableSpan<uint3> data = GPU_indexbuf_get_data(&builder).cast<uint3>();
int tri_count;
if (use_flat_layout) {
create_tri_index_grids_flat_layout(grid_indices, grid_hidden, gridsize, skip, totgrid, data);
tri_count = create_tri_index_grids_flat_layout(
grid_indices, grid_hidden, gridsize, skip, totgrid, data);
}
else {
create_tri_index_grids(grid_indices, grid_hidden, gridsize, skip, totgrid, data);
tri_count = create_tri_index_grids(grid_indices, grid_hidden, gridsize, skip, totgrid, data);
}
return gpu::IndexBufPtr(GPU_indexbuf_build_ex(&builder, 0, 6 * visible_quad_len, false));
builder.index_len = tri_count * 3;
builder.index_min = 0;
builder.index_max = 6 * visible_quad_len;
builder.uses_restart_indices = false;
gpu::IndexBufPtr result = gpu::IndexBufPtr(GPU_indexbuf_calloc());
GPU_indexbuf_build_in_place(&builder, result.get());
return result;
}
static gpu::IndexBufPtr create_lines_index_grids(const CCGKey &key,