griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Pose Library: Remove unused asset view template leftovers

Browse Source 
The pose library now uses the asset shelf and has a dedicated context menu for
that. This UI-list context menu for the asset view template isn't in use
anymore. Neither are the custom properties that were only necessary for the
template.

Pull Request: https://projects.blender.org/blender/blender/pulls/122768
This commit is contained in:
Julian Eisel
2024-06-10 11:52:35 +02:00
committed by Julian Eisel
parent 6334fdc988
commit 63de458f7d
1 changed files with 6 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
scripts/addons_core/pose_library/gui.py
View File

@@ -80,16 +80,7 @@ class VIEW3D_PT_pose_library_legacy(PoseLibraryPanel, Panel):
layout.operator("screen.region_toggle", text="Toggle Asset Shelf").region_type = 'ASSET_SHELF'
def pose_library_list_item_context_menu(self: UIList, context: Context) -> None:
def is_pose_asset_view() -> bool:
# Important: Must check context first, or the menu is added for every kind of list.
list = getattr(context, "ui_list", None)
if not list or list.bl_idname != "UI_UL_asset_view" or list.list_id != "pose_assets":
return False
if not context.active_file:
return False
return True
def pose_library_asset_browser_context_menu(self: UIList, context: Context) -> None:
def is_pose_library_asset_browser() -> bool:
asset_library_ref = getattr(context, "asset_library_reference", None)
if not asset_library_ref:
@@ -99,7 +90,7 @@ def pose_library_list_item_context_menu(self: UIList, context: Context) -> None:
return False
return bool(asset.id_type == 'ACTION')
if not is_pose_asset_view() and not is_pose_library_asset_browser():
if not is_pose_library_asset_browser():
return
layout = self.layout
@@ -120,15 +111,10 @@ def pose_library_list_item_context_menu(self: UIList, context: Context) -> None:
props = layout.operator("poselib.pose_asset_select_bones", text="Deselect Pose Bones")
props.select = False
if not is_pose_asset_view():
layout.separator()
layout.operator("asset.assign_action")
layout.separator()
layout.operator("asset.assign_action")
layout.separator()
if is_pose_asset_view():
layout.operator("asset.open_containing_blend_file")
props.select = False
class DOPESHEET_PT_asset_panel(PoseLibraryPanel, Panel):
@@ -225,17 +211,7 @@ _register, _unregister = bpy.utils.register_classes_factory(classes)
def register() -> None:
_register()
WorkSpace.active_pose_asset_index = bpy.props.IntProperty(
name="Active Pose Asset",
# TODO explain which list the index belongs to, or how it can be used to get the pose.
description="Per workspace index of the active pose asset",
)
# Register for window-manager. This is a global property that shouldn't be
# written to files.
WindowManager.pose_assets = bpy.props.CollectionProperty(type=AssetHandle)
bpy.types.UI_MT_list_item_context_menu.prepend(pose_library_list_item_context_menu)
bpy.types.ASSETBROWSER_MT_context_menu.prepend(pose_library_list_item_context_menu)
bpy.types.ASSETBROWSER_MT_context_menu.prepend(pose_library_asset_browser_context_menu)
bpy.types.ASSETBROWSER_MT_editor_menus.append(pose_library_list_item_asset_menu)
register_message_bus()
@@ -248,9 +224,5 @@ def unregister() -> None:
unregister_message_bus()
del WorkSpace.active_pose_asset_index
del WindowManager.pose_assets
bpy.types.UI_MT_list_item_context_menu.remove(pose_library_list_item_context_menu)
bpy.types.ASSETBROWSER_MT_context_menu.remove(pose_library_list_item_context_menu)
bpy.types.ASSETBROWSER_MT_context_menu.remove(pose_library_asset_browser_context_menu)
bpy.types.ASSETBROWSER_MT_editor_menus.remove(pose_library_list_item_asset_menu)