griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Append: Error message when appending liboverrides.

Browse Source 
Depending on things like order or processing etc., appending
liboverrides data could generate error message in the console regarding
invalid override hierarchy data.

While this could probably be solved, it feels fairly brittle and risky
to directly make linked liboverride hierarchies locale anyway, so just
alsways make local copies of these on append.
This commit is contained in:
Bastien Montagne
2025-06-09 17:04:51 +02:00
parent d9138d6689
commit 675438d331
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/blenkernel/intern/blendfile_link_append.cc
View File

@@ -1228,6 +1228,15 @@ static void blendfile_append_define_actions(BlendfileLinkAppendContext &lapp_con
id->name);
item.action = LINK_APPEND_ACT_COPY_LOCAL;
}
else if (ID_IS_LINKED(id) && ID_IS_OVERRIDE_LIBRARY(id)) {
/* While in theory liboverrides can be directly made local, this causes complex potential
* problems, e.g. because hierarchy roots can become temporarily invalid when the root is
* made local, etc.
*
* So for now, simpler to always duplicate linked liboverrides. */
CLOG_INFO(&LOG, 3, "Appended ID '%s' is a liboverride, duplicating it.", id->name);
item.action = LINK_APPEND_ACT_COPY_LOCAL;
}
else {
/* That last action, making linked data directly local, can still be changed to
* #LINK_APPEND_ACT_COPY_LOCAL in the last checks below. This can happen in rare cases with