griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Avoid spacial UI list lookup when not necessary

Browse Source 
This lookup is only necessary for certain events and if not done in a
pie menu, so it can easily be avoided in many cases. Also reduces
variable scope.
This commit is contained in:
Julian Eisel
2024-06-06 11:33:47 +02:00
parent 7e73f10f79
commit 6a14cca1de
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/editors/interface/interface_handlers.cc
View File

@@ -11506,7 +11506,6 @@ static int ui_handle_menus_recursive(bContext *C,
}
else {
uiBlock *block = static_cast<uiBlock *>(menu->region->uiblocks.first);
uiBut *listbox = ui_list_find_mouse_over(menu->region, event);
if (block->flag & UI_BLOCK_RADIAL) {
retval = ui_pie_handler(C, event, menu);
@@ -11514,7 +11513,7 @@ static int ui_handle_menus_recursive(bContext *C,
else if (event->type == LEFTMOUSE || event->val != KM_DBL_CLICK) {
bool handled = false;
if (listbox) {
if (uiBut *listbox = ui_list_find_mouse_over(menu->region, event)) {
const int retval_test = ui_handle_list_event(C, event, menu->region, listbox);
if (retval_test != WM_UI_HANDLER_CONTINUE) {
retval = retval_test;