griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #140129: Vulkan: Race condition render graph submission

Browse Source 
When queueing render graphs for submission the adding of the queue was
not guarded. This could  still introduce a race condition, although
very unlikely.

Co-authored-by: Jorn Visser <git@jornvisser.com>

Pull Request: https://projects.blender.org/blender/blender/pulls/140517
This commit is contained in:
Jeroen Bakker
2025-06-17 08:57:36 +02:00
parent 2e5b4a120a
commit 701eb56f5e
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
source/blender/gpu/vulkan/vk_device_submission.cc
View File

@@ -74,9 +74,8 @@ TimelineValue VKDevice::render_graph_submit(render_graph::VKRenderGraph *render_
timeline = submit_task->timeline = submit_to_device ? ++timeline_value_ : timeline_value_ + 1;
orphaned_data.timeline_ = timeline;
orphaned_data.move_data(context_discard_pool, timeline);
BLI_thread_queue_push(submitted_render_graphs_, submit_task);
}
BLI_thread_queue_push(submitted_render_graphs_, submit_task);
submit_task = nullptr;
if (wait_for_submission) {