griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

A year-zero bug, and actually another issue with auto-handles for Ipo

Browse Source 
curves. On sharp 'peaking' curves the handle was calculated
using both X and Y distance. This could result in overshooting.

New code only evaluates the X distance, resulting in much more moderate
sized handles.

Thanks Gabio for the demo file!
This commit is contained in:
Ton Roosendaal
2005-11-17 19:34:32 +00:00
parent 43ac5834b6
commit 824ed2e041
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/blenkernel/intern/curve.c
View File

@@ -1956,7 +1956,8 @@ void calchandleNurb(BezTriple *bezt, BezTriple *prev, BezTriple *next, int mode)
dy= p2[1]- p1[1];
dz= p2[2]- p1[2];
}
len1= (float)sqrt(dx*dx+dy*dy+dz*dz);
if(mode) len1= dx;
else len1= (float)sqrt(dx*dx+dy*dy+dz*dz);
if(mode && bezt->h2==HD_AUTO && next) {
dx1= (p3[0]+p3[-3])/2.0f - p2[0];
@@ -1968,7 +1969,8 @@ void calchandleNurb(BezTriple *bezt, BezTriple *prev, BezTriple *next, int mode)
dy1= p3[1]- p2[1];
dz1= p3[2]- p2[2];
}
len2= (float)sqrt(dx1*dx1+dy1*dy1+dz1*dz1);
if(mode) len2= dx1;
else len2= (float)sqrt(dx1*dx1+dy1*dy1+dz1*dz1);
if(len1==0.0f) len1=1.0f;
if(len2==0.0f) len2=1.0f;