griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #147639: Crash When Clicking On Extrude Region in Edit Mode

Browse Source 
Account for change in !141303 which increased the size by 1 returned
by RNA_property_string_length, which now includes the nil byte.
This commit is contained in:
Campbell Barton
2025-10-12 08:43:04 +00:00
parent b42e4052b7
commit 87937059b1
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
source/blender/editors/gizmo_library/gizmo_types/button2d_gizmo.cc
View File

@@ -152,14 +152,16 @@ static void button2d_draw_intern(const bContext *C,
}
else if (RNA_property_is_set(gz->ptr, shape_prop)) {
const uint polys_len = RNA_property_string_length(gz->ptr, shape_prop);
/* We shouldn't need the +1, but a null char is set. */
char *polys = MEM_malloc_arrayN<char>(polys_len + 1, __func__);
RNA_property_string_get(gz->ptr, shape_prop, polys);
button->shape_batch[0] = GPU_batch_tris_from_poly_2d_encoded(
(uchar *)polys, polys_len, nullptr);
button->shape_batch[1] = GPU_batch_wire_from_poly_2d_encoded(
(uchar *)polys, polys_len, nullptr);
MEM_freeN(polys);
if (LIKELY(polys_len > 0)) {
char *polys = MEM_malloc_arrayN<char>(polys_len, __func__);
RNA_property_string_get(gz->ptr, shape_prop, polys);
/* Subtract 1 because this holds a null byte. */
button->shape_batch[0] = GPU_batch_tris_from_poly_2d_encoded(
(const uchar *)polys, polys_len - 1, nullptr);
button->shape_batch[1] = GPU_batch_wire_from_poly_2d_encoded(
(const uchar *)polys, polys_len - 1, nullptr);
MEM_freeN(polys);
}
}
}