griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Remove unnecessary parameter in 'transform_fn' callback

Browse Source 
That `const int[2]` parameter is `t->mval` accessed in a different way
and many times it is not even used.

tmp
This commit is contained in:
Germano Cavalcante
2023-08-02 15:03:58 -03:00
parent 4f673f18af
commit 897f6523ab
32 changed files with 36 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/editors/transform/transform.cc
View File

@@ -2111,7 +2111,7 @@ void transformApply(bContext *C, TransInfo *t)
if (t->redraw == TREDRAW_HARD) {
selectConstraint(t);
if (t->mode_info) {
t->mode_info->transform_fn(t, t->mval); /* calls recalc_data() */
t->mode_info->transform_fn(t); /* calls recalc_data() */
}
}

2
source/blender/editors/transform/transform_mode.hh
View File

@@ -24,7 +24,7 @@ struct TransModeInfo {
void (*init_fn)(TransInfo *, wmOperator *);
/** Main transform mode function. */
void (*transform_fn)(TransInfo *, const int[2]);
void (*transform_fn)(TransInfo *);
/**
* Optional callback to transform a single matrix.

2
source/blender/editors/transform/transform_mode_align.cc
View File

@@ -25,7 +25,7 @@
/** \name Transform (Align)
* \{ */
static void applyAlign(TransInfo *t, const int[2] /*mval*/)
static void applyAlign(TransInfo *t)
{
float center[3];
int i;

4
source/blender/editors/transform/transform_mode_baketime.cc
View File

@@ -30,7 +30,7 @@
/** \name Transform (Bake-Time)
* \{ */
static void applyBakeTime(TransInfo *t, const int mval[2])
static void applyBakeTime(TransInfo *t)
{
float time;
int i;
@@ -49,7 +49,7 @@ static void applyBakeTime(TransInfo *t, const int mval[2])
else
#endif
{
time = float(t->center2d[0] - mval[0]) * fac;
time = (t->center2d[0] - t->mval[0]) * fac;
}
transform_snap_increment(t, &time);

2
source/blender/editors/transform/transform_mode_bbone_resize.cc
View File

@@ -95,7 +95,7 @@ static void ElementBoneSize(TransInfo *t,
td->loc[1] = oldy;
}
static void applyBoneSize(TransInfo *t, const int[2] /*mval*/)
static void applyBoneSize(TransInfo *t)
{
float mat[3][3];
int i;

2
source/blender/editors/transform/transform_mode_bend.cc
View File

@@ -180,7 +180,7 @@ static eRedrawFlag handleEventBend(TransInfo * /*t*/, const wmEvent *event)
return status;
}
static void Bend(TransInfo *t, const int[2] /*mval*/)
static void Bend(TransInfo *t)
{
float pivot_global[3];
float warp_end_radius_global[3];

2
source/blender/editors/transform/transform_mode_boneenvelope.cc
View File

@@ -30,7 +30,7 @@
/** \name Transform (Bone Envelope)
* \{ */
static void applyBoneEnvelope(TransInfo *t, const int[2] /*mval*/)
static void applyBoneEnvelope(TransInfo *t)
{
float ratio;
int i;

2
source/blender/editors/transform/transform_mode_boneroll.cc
View File

@@ -30,7 +30,7 @@
/** \name Transform (EditBone Roll)
* \{ */
static void applyBoneRoll(TransInfo *t, const int[2] /*mval*/)
static void applyBoneRoll(TransInfo *t)
{
int i;
char str[UI_MAX_DRAW_STR];

2
source/blender/editors/transform/transform_mode_curveshrinkfatten.cc
View File

@@ -31,7 +31,7 @@
/** \name Transform (Curve Shrink/Fatten)
* \{ */
static void applyCurveShrinkFatten(TransInfo *t, const int[2] /*mval*/)
static void applyCurveShrinkFatten(TransInfo *t)
{
float ratio;
int i;

4
source/blender/editors/transform/transform_mode_customdata.cc
View File

@@ -136,12 +136,12 @@ static void apply_value_impl(TransInfo *t, const char *value_name)
ED_area_status_text(t->area, str);
}
static void applyCrease(TransInfo *t, const int[2] /*mval*/)
static void applyCrease(TransInfo *t)
{
apply_value_impl(t, TIP_("Crease"));
}
static void applyBevelWeight(TransInfo *t, const int[2] /*mval*/)
static void applyBevelWeight(TransInfo *t)
{
apply_value_impl(t, TIP_("Bevel Weight"));
}

2
source/blender/editors/transform/transform_mode_edge_rotate_normal.cc
View File

@@ -60,7 +60,7 @@ void freeCustomNormalArray(TransInfo *t, TransDataContainer *tc, TransCustomData
}
/* Works by getting custom normal from clnor_data, transform, then store */
static void applyNormalRotation(TransInfo *t, const int[2] /*mval*/)
static void applyNormalRotation(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];

2
source/blender/editors/transform/transform_mode_edge_seq_slide.cc
View File

@@ -71,7 +71,7 @@ static void applySeqSlideValue(TransInfo *t, const float val[2])
}
}
static void applySeqSlide(TransInfo *t, const int[2] /*mval*/)
static void applySeqSlide(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];
float values_final[3] = {0.0f};

2
source/blender/editors/transform/transform_mode_edge_slide.cc
View File

@@ -1433,7 +1433,7 @@ static void doEdgeSlide(TransInfo *t, float perc)
}
}
static void applyEdgeSlide(TransInfo *t, const int[2] /*mval*/)
static void applyEdgeSlide(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];
size_t ofs = 0;

2
source/blender/editors/transform/transform_mode_gpopacity.cc
View File

@@ -32,7 +32,7 @@
/** \name Transform (GPencil Strokes Opacity)
* \{ */
static void applyGPOpacity(TransInfo *t, const int[2] /*mval*/)
static void applyGPOpacity(TransInfo *t)
{
float ratio;
int i;

2
source/blender/editors/transform/transform_mode_gpshrinkfatten.cc
View File

@@ -32,7 +32,7 @@
/** \name Transform (GPencil Strokes Shrink/Fatten)
* \{ */
static void applyGPShrinkFatten(TransInfo *t, const int[2] /*mval*/)
static void applyGPShrinkFatten(TransInfo *t)
{
float ratio;
int i;

2
source/blender/editors/transform/transform_mode_maskshrinkfatten.cc
View File

@@ -30,7 +30,7 @@
/** \name Transform (Mask Shrink/Fatten)
* \{ */
static void applyMaskShrinkFatten(TransInfo *t, const int[2] /*mval*/)
static void applyMaskShrinkFatten(TransInfo *t)
{
float ratio;
int i;

2
source/blender/editors/transform/transform_mode_mirror.cc
View File

@@ -152,7 +152,7 @@ static void ElementMirror(TransInfo *t, TransDataContainer *tc, TransData *td, i
}
}
static void applyMirror(TransInfo *t, const int[2] /*mval*/)
static void applyMirror(TransInfo *t)
{
int i;
char str[UI_MAX_DRAW_STR];

2
source/blender/editors/transform/transform_mode_push_pull.cc
View File

@@ -102,7 +102,7 @@ static void transdata_elem_push_pull_fn(void *__restrict iter_data_v,
/** \name Transform (Push/Pull)
* \{ */
static void applyPushPull(TransInfo *t, const int[2] /*mval*/)
static void applyPushPull(TransInfo *t)
{
float axis_global[3];
float distance;

2
source/blender/editors/transform/transform_mode_resize.cc
View File

@@ -187,7 +187,7 @@ static bool clip_uv_transform_resize(TransInfo *t, float vec[2])
return scale != 1.0f;
}
static void applyResize(TransInfo *t, const int[2] /*mval*/)
static void applyResize(TransInfo *t)
{
float mat[3][3];
int i;

2
source/blender/editors/transform/transform_mode_rotate.cc
View File

@@ -332,7 +332,7 @@ static bool clip_uv_transform_rotate(const TransInfo *t, float *vec, float *vec_
return true;
}
static void applyRotation(TransInfo *t, const int[2] /*mval*/)
static void applyRotation(TransInfo *t)
{
float axis_final[3];
float final = t->values[0] + t->values_modal_offset[0];

2
source/blender/editors/transform/transform_mode_shear.cc
View File

@@ -279,7 +279,7 @@ static bool clip_uv_transform_shear(const TransInfo *t, float *vec, float *vec_i
return true;
}
static void apply_shear(TransInfo *t, const int[2] /*mval*/)
static void apply_shear(TransInfo *t)
{
float value = t->values[0] + t->values_modal_offset[0];
transform_snap_increment(t, &value);

2
source/blender/editors/transform/transform_mode_shrink_fatten.cc
View File

@@ -88,7 +88,7 @@ static eRedrawFlag shrinkfatten_handleEvent(TransInfo *t, const wmEvent *event)
return TREDRAW_NOTHING;
}
static void applyShrinkFatten(TransInfo *t, const int[2] /*mval*/)
static void applyShrinkFatten(TransInfo *t)
{
float distance;
int i;

2
source/blender/editors/transform/transform_mode_skin_resize.cc
View File

@@ -81,7 +81,7 @@ static void transdata_elem_skin_resize_fn(void *__restrict iter_data_v,
/** \name Transform (Skin)
* \{ */
static void applySkinResize(TransInfo *t, const int[2] /*mval*/)
static void applySkinResize(TransInfo *t)
{
float mat_final[3][3];
int i;

2
source/blender/editors/transform/transform_mode_snapsource.cc
View File

@@ -148,7 +148,7 @@ static eRedrawFlag snapsource_handle_event_fn(TransInfo *t, const wmEvent *event
return TREDRAW_NOTHING;
}
static void snapsource_transform_fn(TransInfo *t, const int[2] /*mval*/)
static void snapsource_transform_fn(TransInfo *t)
{
BLI_assert(t->modifiers & MOD_EDIT_SNAP_SOURCE);

2
source/blender/editors/transform/transform_mode_tilt.cc
View File

@@ -30,7 +30,7 @@
/** \name Transform (Tilt)
* \{ */
static void applyTilt(TransInfo *t, const int[2] /*mval*/)
static void applyTilt(TransInfo *t)
{
int i;
char str[UI_MAX_DRAW_STR];

2
source/blender/editors/transform/transform_mode_timescale.cc
View File

@@ -77,7 +77,7 @@ static void applyTimeScaleValue(TransInfo *t, float value)
}
}
static void applyTimeScale(TransInfo *t, const int[2] /*mval*/)
static void applyTimeScale(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];

4
source/blender/editors/transform/transform_mode_timeslide.cc
View File

@@ -118,7 +118,7 @@ static void applyTimeSlideValue(TransInfo *t, float sval, float cval)
}
}
static void applyTimeSlide(TransInfo *t, const int mval[2])
static void applyTimeSlide(TransInfo *t)
{
View2D *v2d = (View2D *)t->view;
float cval[2], sval[2];
@@ -128,7 +128,7 @@ static void applyTimeSlide(TransInfo *t, const int mval[2])
char str[UI_MAX_DRAW_STR];
/* calculate mouse co-ordinates */
UI_view2d_region_to_view(v2d, mval[0], mval[1], &cval[0], &cval[1]);
UI_view2d_region_to_view(v2d, t->mval[0], t->mval[1], &cval[0], &cval[1]);
UI_view2d_region_to_view(v2d, t->mouse.imval[0], t->mouse.imval[1], &sval[0], &sval[1]);
/* t->values_final[0] stores cval[0], which is the current mouse-pointer location (in frames) */

4
source/blender/editors/transform/transform_mode_timetranslate.cc
View File

@@ -91,7 +91,7 @@ static void applyTimeTranslateValue(TransInfo *t, const float deltax)
}
}
static void applyTimeTranslate(TransInfo *t, const int mval[2])
static void applyTimeTranslate(TransInfo *t)
{
View2D *v2d = (View2D *)t->view;
char str[UI_MAX_DRAW_STR];
@@ -99,7 +99,7 @@ static void applyTimeTranslate(TransInfo *t, const int mval[2])
/* calculate translation amount from mouse movement - in 'time-grid space' */
if (t->flag & T_MODAL) {
float cval[2], sval[2];
UI_view2d_region_to_view(v2d, mval[0], mval[0], &cval[0], &cval[1]);
UI_view2d_region_to_view(v2d, t->mval[0], t->mval[0], &cval[0], &cval[1]);
UI_view2d_region_to_view(v2d, t->mouse.imval[0], t->mouse.imval[0], &sval[0], &sval[1]);
/* we only need to calculate effect for time (applyTimeTranslate only needs that) */

2
source/blender/editors/transform/transform_mode_tosphere.cc
View File

@@ -170,7 +170,7 @@ static void transdata_elem_to_sphere_fn(void *__restrict iter_data_v,
/** \name Transform (ToSphere)
* \{ */
static void applyToSphere(TransInfo *t, const int[2] /*mval*/)
static void applyToSphere(TransInfo *t)
{
const bool is_local_center = transdata_check_local_center(t, t->around);
const bool is_data_space = (t->options & CTX_POSE_BONE) != 0;

2
source/blender/editors/transform/transform_mode_trackball.cc
View File

@@ -122,7 +122,7 @@ static void applyTrackballValue(TransInfo *t, const float axis[3], const float a
}
}
static void applyTrackball(TransInfo *t, const int[2] /*mval*/)
static void applyTrackball(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];
size_t ofs = 0;

2
source/blender/editors/transform/transform_mode_translate.cc
View File

@@ -573,7 +573,7 @@ static bool clip_uv_transform_translation(TransInfo *t, float vec[2])
return result;
}
static void applyTranslation(TransInfo *t, const int[2] /*mval*/)
static void applyTranslation(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];
float global_dir[3] = {0.0f};

2
source/blender/editors/transform/transform_mode_vert_slide.cc
View File

@@ -561,7 +561,7 @@ static void vert_slide_snap_apply(TransInfo *t, float *value)
*value = line_point_factor_v3(snap_point, co_orig_3d, co_curr_3d);
}
static void applyVertSlide(TransInfo *t, const int[2] /*mval*/)
static void applyVertSlide(TransInfo *t)
{
char str[UI_MAX_DRAW_STR];
size_t ofs = 0;