griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #141085: Cycles adaptive subdivision crash with zero length edges

Browse Source 
As produced by booleans in the reported blend file.

Pull Request: https://projects.blender.org/blender/blender/pulls/141105
This commit is contained in:
Brecht Van Lommel
2025-06-28 00:03:45 +02:00
committed by Brecht Van Lommel
parent 0354d2e02c
commit 9711efece7
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
intern/cycles/subd/split.cpp
View File

@@ -593,11 +593,14 @@ void DiagSplit::split_triangle(SubPatch &&sub)
* platforms rather than choice being decided by precision. */
const float bias = 1.00012345f;
/* Pick longest edge that must be split. */
float max_length = 0;
int split_index_0 = 0;
/* Pick longest edge that must be split. Note that in degenerate cases edges may have
* zero length but still requires splitting at depth 0. */
float max_length = 0.0f;
int split_index_0 = -1;
for (int i = 0; i < 3; i++) {
if (sub.edges[i].edge->must_split() && sub.edges[i].edge->length > max_length) {
if (sub.edges[i].edge->must_split() &&
(split_index_0 == -1 || sub.edges[i].edge->length > max_length))
{
split_index_0 = i;
max_length = sub.edges[i].edge->length * bias;
}