griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #134082: Clarify description for subsurface scattering radius

Browse Source 
User may think of the `radius` vector value as RGB color, however it's
meant to be the depth of scattering for R/G/B channels. Now clarified in
the desctiption.

Pull Request: https://projects.blender.org/blender/blender/pulls/134088
This commit is contained in:
YimingWu
2025-02-06 12:23:23 +01:00
committed by YimingWu
parent 3b49b5b587
commit 981f9f767d
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/nodes/shader/nodes/node_shader_bsdf_principled.cc
View File

@@ -98,7 +98,7 @@ static void node_declare(NodeDeclarationBuilder &b)
.min(0.0f)
.max(100.0f)
.short_label("Radius")
.description("Scattering radius to use for subsurface component (multiplied with Scale)");
.description("Scattering radius per color channel (RGB), multiplied with Scale");
#define SOCK_SUBSURFACE_RADIUS_ID 9
sss.add_input<decl::Float>("Subsurface Scale")
.default_value(0.05f)
@@ -106,7 +106,7 @@ static void node_declare(NodeDeclarationBuilder &b)
.max(10.0f)
.subtype(PROP_DISTANCE)
.short_label("Scale")
.description("Scale of the subsurface scattering (multiplied with Radius)");
.description("Scale factor of the subsurface scattering radius");
#define SOCK_SUBSURFACE_SCALE_ID 10
sss.add_input<decl::Float>("Subsurface IOR")
.default_value(1.4f)

9
source/blender/nodes/shader/nodes/node_shader_subsurface_scattering.cc
View File

@@ -16,8 +16,13 @@ namespace blender::nodes::node_shader_subsurface_scattering_cc {
static void node_declare(NodeDeclarationBuilder &b)
{
b.add_input<decl::Color>("Color").default_value({0.8f, 0.8f, 0.8f, 1.0f});
b.add_input<decl::Float>("Scale").default_value(0.05f).min(0.0f).max(1000.0f);
b.add_input<decl::Vector>("Radius").default_value({1.0f, 0.2f, 0.1f}).min(0.0f).max(100.0f);
b.add_input<decl::Float>("Scale").default_value(0.05f).min(0.0f).max(1000.0f).description(
"Scale factor of the subsurface scattering radius");
b.add_input<decl::Vector>("Radius")
.default_value({1.0f, 0.2f, 0.1f})
.min(0.0f)
.max(100.0f)
.description("Scattering radius per color channel (RGB), multiplied with Scale");
b.add_input<decl::Float>("IOR").default_value(1.4f).min(1.01f).max(3.8f).subtype(PROP_FACTOR);
b.add_input<decl::Float>("Roughness")
.default_value(1.0f)