griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix part of T69728: drawing glitches with sculpt dynamic mesh preview

Browse Source 
Depth test must default to off for drawing outside the 3D viewport and
overlays like cursors.
This commit is contained in:
Brecht Van Lommel
2019-09-17 12:15:21 +02:00
parent 398de6a86f
commit 9be5a94cf3
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/editors/sculpt_paint/paint_cursor.c
View File

@@ -1191,7 +1191,13 @@ static void cursor_draw_point_with_symmetry(const uint gpuattr,
static void sculpt_geometry_preview_lines_draw(const uint gpuattr, SculptSession *ss)
{
immUniformColor4f(1.0f, 1.0f, 1.0f, 0.6f);
GPU_depth_test(true);
/* Cursor normally draws on top, but for this part we need depth tests. */
const bool depth_test = GPU_depth_test_enabled();
if (!depth_test) {
GPU_depth_test(true);
}
GPU_line_width(1.0f);
if (ss->preview_vert_index_count > 0) {
immBegin(GPU_PRIM_LINES, ss->preview_vert_index_count);
@@ -1200,6 +1206,11 @@ static void sculpt_geometry_preview_lines_draw(const uint gpuattr, SculptSession
}
immEnd();
}
/* Restore depth test value. */
if (!depth_test) {
GPU_depth_test(false);
}
}
static void paint_draw_cursor(bContext *C, int x, int y, void *UNUSED(unused))