griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #112931: Cycles mesh light sampling artifacts

Browse Source
This commit is contained in:
Brecht Van Lommel
2023-10-02 19:16:08 +02:00
parent ed36398e16
commit a455eca7a0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
intern/cycles/kernel/light/triangle.h
View File

@@ -79,8 +79,8 @@ ccl_device_forceinline float triangle_light_pdf(KernelGlobals kg,
const float3 B = safe_normalize(V[1] - Px);
const float3 C = safe_normalize(V[2] - Px);
const float solid_angle = 2.0f * fast_atanf(fabsf(dot(A, cross(B, C))) /
(1.0f + dot(B, C) + dot(A, C) + dot(A, B)));
const float solid_angle = 2.0f * fast_atan2f(fabsf(dot(A, cross(B, C))),
(1.0f + dot(B, C) + dot(A, C) + dot(A, B)));
/* distribution_pdf_triangles is calculated over triangle area, but we're not sampling over
* its area */
@@ -174,7 +174,7 @@ ccl_device_forceinline bool triangle_light_sample(KernelGlobals kg,
const float mixed_product = fabsf(dot(A, cross(B, C)));
/* The area of the spherical triangle is equal to the subtended solid angle. */
const float solid_angle = 2.0f * fast_atanf(mixed_product / (1.0f + cos_a + cos_b + cos_c));
const float solid_angle = 2.0f * fast_atan2f(mixed_product, (1.0f + cos_a + cos_b + cos_c));
/* Select a random sub-area of the spherical triangle and calculate the third vertex C_ of that
* new triangle. */