griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: LibOverride: Do not assign default callbacks to RNA properties.

Browse Source 
These default assignements have not actually been needed/useful since a
very long time already. It was likely a left-over from early stages of
the project. While not a problem so far, it makes it harder to
distinguish RNA properties whith a custom liboverride handling, from the
ones using the default code.

Keeping them to `nullptr` by default also makes these callbacks definition
behavior more in line with other RNA properties callbacks, which are
usually non-null only when a custom function is defined.

No behavioral changes are expected from this commit.
This commit is contained in:
Bastien Montagne
2024-05-31 15:34:19 +02:00
committed by Bastien Montagne
parent 916268bed9
commit aa9599119a
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/blender/makesrna/intern/rna_define.cc
View File

@@ -1498,14 +1498,6 @@ PropertyRNA *RNA_def_property(StructOrFunctionRNA *cont_,
#endif
}
/* Override handling. */
if (DefRNA.preprocess) {
prop->override_diff = (RNAPropOverrideDiff)(void *)"rna_property_override_diff_default";
prop->override_store = (RNAPropOverrideStore)(void *)"rna_property_override_store_default";
prop->override_apply = (RNAPropOverrideApply)(void *)"rna_property_override_apply_default";
}
/* TODO: do we want that for runtime-defined stuff too? I’d say no, but... maybe yes :/ */
#ifndef RNA_RUNTIME
/* Both are typically cleared. */
RNA_def_property_update(