griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #147283: Socket lookup by index fails when the node group is missing

Browse Source 
The link-insert operator was doing index lookup for node socket declarations
based on the `bNodeSocket` index, which fails when the node group data block
is missing. The safe approach to this is to use the existing declarations and
look up the node socket from that.

Pull Request: https://projects.blender.org/blender/blender/pulls/147528
This commit is contained in:
Lukas Tönne
2025-10-07 16:18:34 +02:00
parent a6cea64b3a
commit abba67fd79
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
source/blender/editors/space_node/node_relationships.cc
View File

@@ -2844,13 +2844,12 @@ bNodeSocket *get_main_socket(bNodeTree &ntree, bNode &node, eNodeSocketInOut in_
if (node_decl != nullptr) {
Span<nodes::SocketDeclaration *> socket_decls = (in_out == SOCK_IN) ? node_decl->inputs :
node_decl->outputs;
int index;
LISTBASE_FOREACH_INDEX (bNodeSocket *, socket, sockets, index) {
const nodes::SocketDeclaration &socket_decl = *socket_decls[index];
if (!socket->is_visible()) {
for (const nodes::SocketDeclaration *socket_decl : socket_decls) {
if (!socket_decl->is_default_link_socket) {
continue;
}
if (socket_decl.is_default_link_socket) {
bNodeSocket *socket = static_cast<bNodeSocket *>(BLI_findlink(sockets, socket_decl->index));
if (socket && socket->is_visible()) {
return socket;
}
}