griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Crash when versioning Translate node

Browse Source 
Blender crashes when versioning the Translate node due to a nullptr
storage. This happens due to an inverted nullptr check.

Additionally, we remove redundant assignments from other versioning code
for safety.

Pull Request: https://projects.blender.org/blender/blender/pulls/143046
This commit is contained in:
Omar Emara
2025-07-24 11:56:07 +02:00
committed by Omar Emara
parent 25d4ac38b1
commit b0db491f24
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/blenloader/intern/versioning_500.cc
View File

@@ -1407,7 +1407,7 @@ void blo_do_versions_500(FileData * /*fd*/, Library * /*lib*/, Main *bmain)
if (node->type_legacy != CMP_NODE_TRANSLATE) {
continue;
}
if (node->storage != nullptr) {
if (node->storage == nullptr) {
continue;
}
NodeTranslateData *data = static_cast<NodeTranslateData *>(node->storage);
@@ -1430,7 +1430,6 @@ void blo_do_versions_500(FileData * /*fd*/, Library * /*lib*/, Main *bmain)
data->extension_y = CMP_NODE_EXTENSION_MODE_REPEAT;
break;
}
node->storage = data;
}
FOREACH_NODETREE_END;
}
@@ -1475,7 +1474,6 @@ void blo_do_versions_500(FileData * /*fd*/, Library * /*lib*/, Main *bmain)
NodeScaleData *data = static_cast<NodeScaleData *>(node->storage);
data->extension_x = CMP_NODE_EXTENSION_MODE_ZERO;
data->extension_y = CMP_NODE_EXTENSION_MODE_ZERO;
node->storage = data;
}
FOREACH_NODETREE_END;
}