Cleanup: pass arguments by const reference instead of value

source/blender/compositor/realtime_compositor/COM_render_context.hh

@@ -49,7 +49,10 @@ class FileOutput {
  public:
   /* Allocate and initialize the internal render result of the file output using the give
    * parameters. See the implementation for more information. */
-  FileOutput(std::string path, ImageFormatData format, int2 size, bool save_as_render);
+  FileOutput(const std::string &path,
+             const ImageFormatData &format,
+             int2 size,
+             bool save_as_render);
 
   /* Free the internal render result. */
   ~FileOutput();

source/blender/compositor/realtime_compositor/cached_resources/COM_distortion_grid.hh

@@ -36,7 +36,7 @@ class DistortionGridKey {
   DistortionType type;
   int2 calibration_size;
 
-  DistortionGridKey(MovieTrackingCamera camera,
+  DistortionGridKey(const MovieTrackingCamera &camera,
                     int2 size,
                     DistortionType type,
                     int2 calibration_size);

source/blender/compositor/realtime_compositor/cached_resources/COM_ocio_color_space_conversion_shader.hh

@@ -22,9 +22,9 @@ class OCIOColorSpaceConversionShaderKey {
   std::string target;
   std::string config_cache_id;
 
-  OCIOColorSpaceConversionShaderKey(std::string source,
-                                    std::string target,
-                                    std::string config_cache_id);
+  OCIOColorSpaceConversionShaderKey(const std::string &source,
+                                    const std::string &target,
+                                    const std::string &config_cache_id);
 
   uint64_t hash() const;
 };

source/blender/compositor/realtime_compositor/cached_resources/intern/distortion_grid.cc

@@ -30,7 +30,7 @@ namespace blender::realtime_compositor {
  * Distortion Grid Key.
  */
 
-DistortionGridKey::DistortionGridKey(MovieTrackingCamera camera,
+DistortionGridKey::DistortionGridKey(const MovieTrackingCamera &camera,
                                      int2 size,
                                      DistortionType type,
                                      int2 calibration_size)

source/blender/compositor/realtime_compositor/cached_resources/intern/ocio_color_space_conversion_shader.cc

@@ -34,9 +34,8 @@ namespace blender::realtime_compositor {
  * OCIO Color Space Conversion Shader Key.
  */
 
-OCIOColorSpaceConversionShaderKey::OCIOColorSpaceConversionShaderKey(std::string source,
-                                                                     std::string target,
-                                                                     std::string config_cache_id)
+OCIOColorSpaceConversionShaderKey::OCIOColorSpaceConversionShaderKey(
+    const std::string &source, const std::string &target, const std::string &config_cache_id)
     : source(source), target(target), config_cache_id(config_cache_id)
 {
 }

source/blender/compositor/realtime_compositor/intern/render_context.cc

@@ -34,7 +34,10 @@ namespace blender::realtime_compositor {
  * File Output
  */
 
-FileOutput::FileOutput(std::string path, ImageFormatData format, int2 size, bool save_as_render)
+FileOutput::FileOutput(const std::string &path,
+                       const ImageFormatData &format,
+                       int2 size,
+                       bool save_as_render)
     : path_(path), format_(format), save_as_render_(save_as_render)
 {
   render_result_ = MEM_cnew<RenderResult>("Temporary Render Result For File Output");