griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert "Fix #119455: Auto smooth versioning on append applies to existing IDs"

Browse Source 
This reverts commit c6497dd9f7.

This wasn't working the way I expected, it seems the LIB_TAG_NEW isn't
set here. Better to address the fundamental issues anyway. Sorry for
the noise.
This commit is contained in:
Hans Goudey
2024-03-15 15:17:32 -04:00
parent c6497dd9f7
commit ba430d1d22
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/blenkernel/BKE_mesh_legacy_convert.hh
View File

@@ -114,7 +114,7 @@ void BKE_mesh_calc_edges_legacy(Mesh *mesh);
void BKE_mesh_do_versions_cd_flag_init(Mesh *mesh);
void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain, bool new_ids_only = false);
void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain);
/**
* Calculate/create edges from tessface data

2
source/blender/blenkernel/intern/blendfile_link_append.cc
View File

@@ -1375,10 +1375,10 @@ void BKE_blendfile_append(BlendfileLinkAppendContext *lapp_context, ReportList *
instantiate_context.active_collection = nullptr;
loose_data_instantiate(&instantiate_context);
BKE_main_mesh_legacy_convert_auto_smooth(*bmain, true);
BKE_main_id_newptr_and_tag_clear(bmain);
blendfile_link_append_proxies_convert(bmain, reports);
BKE_main_mesh_legacy_convert_auto_smooth(*bmain);
}
void BKE_blendfile_link(BlendfileLinkAppendContext *lapp_context, ReportList *reports)

5
source/blender/blenkernel/intern/mesh_legacy_convert.cc
View File

@@ -2263,7 +2263,7 @@ static ModifierData *create_auto_smooth_modifier(Object &object,
} // namespace blender::bke
void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain, const bool new_ids_only)
void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain)
{
using namespace blender::bke;
@@ -2279,9 +2279,6 @@ void BKE_main_mesh_legacy_convert_auto_smooth(Main &bmain, const bool new_ids_on
if (object->type != OB_MESH) {
continue;
}
if (new_ids_only && (object->id.tag & LIB_TAG_NEW) == 0) {
continue;
}
Mesh *mesh = static_cast<Mesh *>(object->data);
const float angle = mesh->smoothresh_legacy;
if (!(mesh->flag & ME_AUTOSMOOTH_LEGACY)) {