griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Simplify outliner tree element assert

Browse Source 
Having a `0` condition can be a bit confusing, rather have the proper
condition there so it will also get printed like this to the console.
This commit is contained in:
Julian Eisel
2023-08-31 13:16:01 +02:00
parent 4a689ea7ee
commit ba44afae5e
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
source/blender/editors/space_outliner/outliner_tree.cc
View File

@@ -366,19 +366,16 @@ TreeElement *outliner_add_element(SpaceOutliner *space_outliner,
/* pass */
}
else if (type == TSE_SOME_ID) {
if (!te->abstract_element) {
BLI_assert_msg(0, "Expected this ID type to be ported to new Outliner tree-element design");
}
BLI_assert_msg(te->abstract_element != nullptr,
"Expected this ID type to be ported to new Outliner tree-element design");
}
else if (ELEM(type,
TSE_LIBRARY_OVERRIDE_BASE,
TSE_LIBRARY_OVERRIDE,
TSE_LIBRARY_OVERRIDE_OPERATION))
{
if (!te->abstract_element) {
BLI_assert_msg(0,
"Expected override types to be ported to new Outliner tree-element design");
}
BLI_assert_msg(te->abstract_element != nullptr,
"Expected override types to be ported to new Outliner tree-element design");
}
else {
/* Other cases must be caught above. */