griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

GPUCodegen: Use spin lock to protect the pass refcounter.

Browse Source 
This is not performance critical so using the same global lock should not
pose any issue.
This commit is contained in:
Clément Foucault
2022-04-27 15:29:53 +02:00
parent 163f6a17e4
commit c01e33d6ca
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/gpu/intern/gpu_codegen.cc
View File

@@ -571,7 +571,9 @@ GPUPass *GPU_generate_pass(GPUMaterial *material,
return nullptr;
}
/* No collision, just return the pass. */
BLI_spin_lock(&pass_cache_spin);
pass_hash->refcount += 1;
BLI_spin_unlock(&pass_cache_spin);
return pass_hash;
}
@@ -597,7 +599,9 @@ GPUPass *GPU_generate_pass(GPUMaterial *material,
/* Shader has already been created but failed to compile. */
return nullptr;
}
BLI_spin_lock(&pass_cache_spin);
pass->refcount += 1;
BLI_spin_unlock(&pass_cache_spin);
}
else {
/* We still create a pass even if shader compilation
@@ -697,8 +701,10 @@ GPUShader *GPU_pass_shader_get(GPUPass *pass)
void GPU_pass_release(GPUPass *pass)
{
BLI_spin_lock(&pass_cache_spin);
BLI_assert(pass->refcount > 0);
pass->refcount--;
BLI_spin_unlock(&pass_cache_spin);
}
static void gpu_pass_free(GPUPass *pass)